Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Google TypeScript Style #1526

Closed
bartekleon opened this issue Apr 25, 2019 · 3 comments
Closed

Use Google TypeScript Style #1526

bartekleon opened this issue Apr 25, 2019 · 3 comments

Comments

@bartekleon
Copy link
Member

Searching through the internet I have found quite interesting repository https://github.com/google/gts (Google TypeScript Style), created by Google (WoW), which just add TypeScript style guide, formatter, and linter. It is built on Tslint and prettier. I would remove the necessity of looking for TSlint updates, updating 'stylesheets', everything would be always up to date with Google's standards.
It would also close all my current and future (probably) issues about style conventions.

(although we still can update it's config:
Opinionated, but not to a fault. We recommend you use the default configuration, but if you need to customize compiler or linter config, you can.)

Looking for your feedback bout it :)

@nicojs
Copy link
Member

nicojs commented Apr 26, 2019

Hmm I like this approach. We need to migrate to eslint sooner or later, might as well migrate to this instead.

What would the impact on code be? Are we in line with the "Google style" (can't seem to find documentation on what that is exactly)?

@bartekleon
Copy link
Member Author

bartekleon commented Apr 26, 2019

@nicojs this is basically the preset TSlint config, with the most common rules and used by google (or at least recommended) + configures prettier. What do you mean by "migrate to eslint"? As we are using mostly Typescript I don't find any sense of using ESlint :/
Impact on code? I guess not that big, since as you probably remember I have done a lot of work with your linters and so it should be more or less the same config

@bartekleon
Copy link
Member Author

Solved by #1615

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants