This repository has been archived by the owner on Feb 19, 2021. It is now read-only.
fix(jest-config) Fallback to default Jest config if it's not overriden #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicojs
suggested changes
Apr 6, 2018
| @@ -17,7 +17,7 @@ export default class DefaultJestConfigLoader implements JestConfigLoader { | |||
| } | |||
|
|
|||
| public loadConfig(): JestConfiguration { | |||
| const jestConfig = this.readConfigFromJestConfigFile() || this.readConfigFromPackageJson(); | |||
| const jestConfig = this.readConfigFromJestConfigFile() || this.readConfigFromPackageJson() || {}; | |||
|
|
|||
| if (!jestConfig) { | |||
| throw new Error('Could not read Jest configuration, please provide a jest.config.js file or a jest config in your package.json'); | |||
There was a problem hiding this comment.
This can be removed right? This error cannot occur?
There was a problem hiding this comment.
You're definitely right! Removed these lines...
nicojs
approved these changes
Apr 6, 2018
|
Released in v0.6 Changelog didn't update correctly, because the name commit was not confirm to the conventional changelog specs. should have been |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Jest config was not overriden (ie., a project uses default Jest settings) Stryker would fail.
Fixes #38