Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test cases to be port independent #9

Open
gunjpan opened this issue Jul 11, 2016 · 4 comments
Open

Update test cases to be port independent #9

gunjpan opened this issue Jul 11, 2016 · 4 comments

Comments

@gunjpan
Copy link

gunjpan commented Jul 11, 2016

Current test cases run server on port 3000, when needed, which crashes other test cases that try to use the same port on same instance causing CI failures.
Goal is to make test server apps port independent.
Parent issue: https://github.com/strongloop-internal/scrum-loopback/issues/932

@bnoordhuis
Copy link
Member

I'm fairly sure all tests honor the PORT environment variable.

@gunjpan
Copy link
Author

gunjpan commented Aug 4, 2016

@bnoordhuis : They do, but on our CI infrastructure, we have seen failures related to multiple builds trying to run test apps on port 3000.

@bnoordhuis
Copy link
Member

What does "our CI" refer to? StrongLoop's? Can you link me to a failing run?

@gunjpan
Copy link
Author

gunjpan commented Aug 4, 2016

I was referring to Strongloop's CI. For the failing run, I get 404 Not found as it has been a while since the issue was created and Jenkins keeps build logs for a limited amount of time.
The initial cause was dependent builds failing with: EADDRINUSE. Will link you to the failing run when I come across one.

The end goal is to make test cases more robust. Any suggestions are appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants