fix(rest): make sure OpenAPI parameters with simple types are validated by AJV #6285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raymondfeng
added
REST
|
@jannyHou Please review. |
jannyHou
approved these changes
Sep 9, 2020
| debug(`Value from ${options.source} passed AJV validation.`); | ||
| return; | ||
| } | ||
| debug( |
There was a problem hiding this comment.
nitpick: I remember checking the null value to pass some test, but if the check is not needed, please also remove the comment above.
…ed by AJV Fixes #6247 Signed-off-by: Raymond Feng <[email protected]>
raymondfeng
force-pushed
the
fix-6247
branch
from
f231045 to
377ad3f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6247
Signed-off-by: Raymond Feng [email protected]
Checklist
npm testpasses on your machinepackages/cliwere updatedexamples/*were updated👉 Check out how to submit a PR 👈