feat(http-server): handle http keepalive connections upon application.stop() #4146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raymondfeng
force-pushed
the
http-keepalive
branch
2 times, most recently
from
7b955b2 to
345217b
Compare
bajtos
suggested changes
Nov 19, 2019
There was a problem hiding this comment.
Nice addition 👏
Have you considered updating our project template(s) to configure a reasonable gracePeriodForClose, for example 1 second? This will make the feature easier to discover, because developers will see it directly in code, no need to search documentation (and know what to search for). If you decide to make this change, then please put it in a new commit (or even a new PR), so that we have meaningful release notes.
Also do we need to update any pages in docs/site to mention this new flag?
packages/http-server/src/__tests__/integration/http-server.integration.ts
Outdated
Show resolved
Hide resolved
packages/http-server/src/__tests__/integration/http-server.integration.ts
Outdated
Show resolved
Hide resolved
raymondfeng
force-pushed
the
http-keepalive
branch
3 times, most recently
from
0365d87 to
69554ba
Compare
emonddr
approved these changes
Nov 19, 2019
bajtos
suggested changes
Nov 22, 2019
packages/http-server/src/__tests__/integration/http-server.integration.ts
Outdated
Show resolved
Hide resolved
raymondfeng
force-pushed
the
http-keepalive
branch
from
69554ba to
d54626f
Compare
|
@bajtos Comments addressed. PTAL. |
raymondfeng
force-pushed
the
http-keepalive
branch
from
d54626f to
ac5d3c2
Compare
bajtos
approved these changes
Nov 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by https://github.com/godaddy/terminus and https://github.com/hunterloftis/stoppable.
Checklist
👉 Read and sign the CLA (Contributor License Agreement) 👈
npm testpasses on your machinepackages/cliwere updatedexamples/*were updated👉 Check out how to submit a PR 👈