test(repository): verify relation type in resolve{Relation}Metadata
#4046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's easier to review if "Hide whitespace changes" is selected. |
raymondfeng
reviewed
Nov 5, 2019
...repository/src/__tests__/integration/repositories/resolve-belongs-to-metadata.integration.ts
Outdated
Show resolved
Hide resolved
raymondfeng
reviewed
Nov 5, 2019
...s/repository/src/__tests__/integration/repositories/resolve-has-many-metadata.integration.ts
Outdated
Show resolved
Hide resolved
raymondfeng
reviewed
Nov 5, 2019
...s/repository/src/__tests__/integration/repositories/resolve-has-many-metadata.integration.ts
Outdated
Show resolved
Hide resolved
nabdelgadir
force-pushed
the
verify-relation-type
branch
from
45c9e60 to
d814165
Compare
raymondfeng
approved these changes
Nov 6, 2019
bajtos
reviewed
Nov 7, 2019
...repository/src/__tests__/integration/repositories/resolve-belongs-to-metadata.integration.ts
Outdated
Show resolved
Hide resolved
nabdelgadir
force-pushed
the
verify-relation-type
branch
from
d814165 to
00c95b1
Compare
bajtos
approved these changes
Nov 8, 2019
There was a problem hiding this comment.
Much better 👏
Personally, I think these tests are unit-level, because they just call resolve{Relation}Metadata with some metadata object, and therefore they belong to src/__tests__/unit/resolve-{name}-metadata.test.js. Such file-moves are best done outside of this pull request though.
nabdelgadir
force-pushed
the
verify-relation-type
branch
from
00c95b1 to
9fc1981
Compare
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3440.
Split into two commits:
1) Added tests to verify the correct relation type is used in
resolve{Relation}Metadata.2) Improved setup for
resolve{Relation}Metadatatests based on #4046 (comment).Checklist
👉 Read and sign the CLA (Contributor License Agreement) 👈
npm testpasses on your machinepackages/cliwere updatedexamples/*were updated👉 Check out how to submit a PR 👈