Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

listening property in the Server interface #1368

Closed
hacksparrow opened this issue May 28, 2018 · 1 comment · Fixed by #1479
Closed

listening property in the Server interface #1368

hacksparrow opened this issue May 28, 2018 · 1 comment · Fixed by #1479
Labels
feature good first issue REST Issues related to @loopback/rest package and REST transport in general

Comments

@hacksparrow
Copy link
Contributor

Description / Steps to reproduce / Feature proposal

How about a listening property in packages/core/Server?

This tells whether the server is running and listening for connections or not.

Current Behavior

Server.listening property does not exist.

Expected Behavior

Server.listening is true or false.

See Reporting Issues for more tips on writing good issues
@jannyHou
Copy link
Contributor

Sounds good to me.
And could potentially make the solution for #822 easier.

@bajtos bajtos added feature post-GA good first issue REST Issues related to @loopback/rest package and REST transport in general labels Jun 25, 2018
@fernandobastos fernandobastos mentioned this issue Jun 26, 2018
Merged
7 tasks
raymondfeng pushed a commit that referenced this issue Jun 27, 2018
@raymondfeng
feat: add listening property in the server interface
ff0eab7 
- Add listening property to Server
- Update start and stop methods in RestServer/RpcServer
- Update http-server to use listening instead of _started
- Update server overview to mention the new property

fix #1368
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature good first issue REST Issues related to @loopback/rest package and REST transport in general
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add listening property in the server interface
3 participants
@hacksparrow @bajtos @jannyHou