Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support applyDefaultOnWrites in nested properties #1797

Merged
merged 1 commit into from
Nov 28, 2019

Conversation

hacksparrow
Copy link
Contributor

@hacksparrow hacksparrow commented Nov 26, 2019

Adds support for applyDefaultOnWrites in nested properties. Addressed loopbackio/loopback-connector-mongodb#552.

Checklist

👉 Read and sign the CLA (Contributor License Agreement) 👈

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • Commit messages are following our guidelines

Copy link
Member

@bajtos bajtos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good, please find a better name for applyDefaultOnWrites per my comment below and get at least one more approval before landing.

lib/model.js Outdated Show resolved Hide resolved
Adds support for `applyDefaultOnWrites` in nested properties.
@hacksparrow hacksparrow force-pushed the feat/nested-applyDefaultOnWrites branch from 6e45e33 to ce7540e Compare November 27, 2019 14:01
Copy link
Contributor

@jannyHou jannyHou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@hacksparrow hacksparrow merged commit 89a964e into master Nov 28, 2019
@delete-merged-branch delete-merged-branch bot deleted the feat/nested-applyDefaultOnWrites branch November 28, 2019 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants