Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Node.js 12.x [3.x] #1729

Merged
merged 1 commit into from
May 2, 2019
Merged

Add support for Node.js 12.x [3.x] #1729

merged 1 commit into from
May 2, 2019

Conversation

bajtos
Copy link
Member

@bajtos bajtos commented Apr 30, 2019 •
edited
Loading

Back-port #1728:

  • Fix code to pass all tests on Node.js 12
  • Add Node.js 12 to the list of Travis CI platforms

@bajtos
Add support for Node.js 12.x
70b3d21 
- Fix code to pass all tests on Node.js 12
- Add Node.js 12 to the list of Travis CI platforms
@bajtos bajtos changed the base branch from master to 3.x April 30, 2019 07:17
@bajtos bajtos changed the title Chore/add node 12 3x Add support for Node.js 12.x Apr 30, 2019
@bajtos bajtos self-assigned this Apr 30, 2019
@bajtos bajtos requested a review from raymondfeng April 30, 2019 07:17
@bajtos bajtos changed the title Add support for Node.js 12.x Add support for Node.js 12.x [2.x] Apr 30, 2019
@hacksparrow hacksparrow self-requested a review May 2, 2019 07:12
hacksparrow
hacksparrow approved these changes May 2, 2019
View reviewed changes
Copy link
Contributor

@hacksparrow hacksparrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@bajtos bajtos changed the title Add support for Node.js 12.x [2.x] Add support for Node.js 12.x [3.x] May 2, 2019
@bajtos bajtos merged commit e27efd9 into 3.x May 2, 2019
@bajtos bajtos deleted the chore/add-node-12-3x branch May 2, 2019 10:58
@dhmlau dhmlau mentioned this pull request Jun 7, 2019
Closed
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nabdelgadir nabdelgadir nabdelgadir approved these changes

@dhmlau dhmlau dhmlau approved these changes

@b-admike b-admike b-admike approved these changes

@hacksparrow hacksparrow hacksparrow approved these changes

@emonddr emonddr Awaiting requested review from emonddr

@jannyHou jannyHou Awaiting requested review from jannyHou

@zbarbuto zbarbuto Awaiting requested review from zbarbuto

@raymondfeng raymondfeng Awaiting requested review from raymondfeng

Assignees

@bajtos bajtos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bajtos @hacksparrow @b-admike @dhmlau @nabdelgadir