From 38312c1cc36b2361ec1d5f0271b7256c5f3bd6c8 Mon Sep 17 00:00:00 2001 From: Richard Marmorstein Date: Wed, 10 Mar 2021 12:02:28 -0500 Subject: [PATCH 01/10] GHA --- .github/workflows/ci.yml | 35 +++++++++++++++++++++++++++++++++++ 1 file changed, 35 insertions(+) create mode 100644 .github/workflows/ci.yml diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml new file mode 100644 index 000000000..c679927d4 --- /dev/null +++ b/.github/workflows/ci.yml @@ -0,0 +1,35 @@ +on: + push: + branches: [ master ] + pull_request: + branches: [ master ] + +jobs: + lint: + runs-on: ubuntu-latest + + steps: + - uses: actions/checkout@v2 + - name: Set up Ruby + uses: actions/setup-ruby@v2 + with: + ruby-version: 2.7 + - name: rubocop + run: rake rubocop + + test: + runs-on: ubuntu-latest + strategy: + matrix: + # ruby-version: [2.3, 2.4, 2.5, 2.6, 2.7, jruby-9.2.7.0] + ruby-version: [2.3, jruby-9.2.7.0] + steps: + - uses: actions/checkout@v2 + - name: Set up Ruby + uses: actions/setup-ruby@v2 + with: + ruby-version: ${{ matrix.ruby-version }} + - name: Start stripe-mock + run: docker run -d -p 12111-12112:12111-12112 stripemock/stripe-mock && sleep 5 + - name: test + run: rake test From 76ded977084a52620f57c0a98b855f218598451f Mon Sep 17 00:00:00 2001 From: Richard Marmorstein Date: Wed, 10 Mar 2021 12:08:49 -0500 Subject: [PATCH 02/10] oops --- .github/workflows/ci.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index c679927d4..cea4cebbd 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -11,7 +11,7 @@ jobs: steps: - uses: actions/checkout@v2 - name: Set up Ruby - uses: actions/setup-ruby@v2 + uses: actions/setup-ruby with: ruby-version: 2.7 - name: rubocop @@ -26,7 +26,7 @@ jobs: steps: - uses: actions/checkout@v2 - name: Set up Ruby - uses: actions/setup-ruby@v2 + uses: actions/setup-ruby with: ruby-version: ${{ matrix.ruby-version }} - name: Start stripe-mock From 47cf0913a56f821bb2de8a6f3f6f591bf6b66e0c Mon Sep 17 00:00:00 2001 From: Richard Marmorstein Date: Wed, 10 Mar 2021 12:10:28 -0500 Subject: [PATCH 03/10] oops --- .github/workflows/ci.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index cea4cebbd..496b6d0b3 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -11,7 +11,7 @@ jobs: steps: - uses: actions/checkout@v2 - name: Set up Ruby - uses: actions/setup-ruby + uses: actions/setup-ruby@v1 with: ruby-version: 2.7 - name: rubocop @@ -26,7 +26,7 @@ jobs: steps: - uses: actions/checkout@v2 - name: Set up Ruby - uses: actions/setup-ruby + uses: actions/setup-ruby@v1 with: ruby-version: ${{ matrix.ruby-version }} - name: Start stripe-mock From c429c0a11a50eb5a25df059dbf030218afd82ffe Mon Sep 17 00:00:00 2001 From: Richard Marmorstein Date: Wed, 10 Mar 2021 12:39:35 -0500 Subject: [PATCH 04/10] oops --- .github/workflows/ci.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 496b6d0b3..ec6a007c3 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -11,7 +11,7 @@ jobs: steps: - uses: actions/checkout@v2 - name: Set up Ruby - uses: actions/setup-ruby@v1 + uses: ruby/setup-ruby@v1 with: ruby-version: 2.7 - name: rubocop @@ -26,7 +26,7 @@ jobs: steps: - uses: actions/checkout@v2 - name: Set up Ruby - uses: actions/setup-ruby@v1 + uses: ruby/setup-ruby@v1 with: ruby-version: ${{ matrix.ruby-version }} - name: Start stripe-mock From 792fa7e438f23ce367c59cc68cb7b3105e6f30cb Mon Sep 17 00:00:00 2001 From: Richard Marmorstein Date: Wed, 10 Mar 2021 12:47:48 -0500 Subject: [PATCH 05/10] Oops --- .github/workflows/ci.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index ec6a007c3..7f03b8689 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -15,7 +15,7 @@ jobs: with: ruby-version: 2.7 - name: rubocop - run: rake rubocop + run: bundle exec rake rubocop test: runs-on: ubuntu-latest @@ -32,4 +32,4 @@ jobs: - name: Start stripe-mock run: docker run -d -p 12111-12112:12111-12112 stripemock/stripe-mock && sleep 5 - name: test - run: rake test + run: bundle exec rake test From 7170f9d06411cc8658b6cf9d46d36d04f96c57f1 Mon Sep 17 00:00:00 2001 From: Richard Marmorstein Date: Wed, 10 Mar 2021 12:53:00 -0500 Subject: [PATCH 06/10] WIP --- .github/workflows/ci.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 7f03b8689..bc2fbca93 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -15,7 +15,7 @@ jobs: with: ruby-version: 2.7 - name: rubocop - run: bundle exec rake rubocop + run: bundle install && bundle exec rake rubocop test: runs-on: ubuntu-latest @@ -32,4 +32,4 @@ jobs: - name: Start stripe-mock run: docker run -d -p 12111-12112:12111-12112 stripemock/stripe-mock && sleep 5 - name: test - run: bundle exec rake test + run: bundle install && bundle exec rake test From 7fc1197396a2c8441acedca75d3a61bc6c7d9e58 Mon Sep 17 00:00:00 2001 From: Richard Marmorstein Date: Wed, 10 Mar 2021 13:22:23 -0500 Subject: [PATCH 07/10] Latest jruby --- .github/workflows/ci.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index bc2fbca93..e38ec7f26 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -21,8 +21,7 @@ jobs: runs-on: ubuntu-latest strategy: matrix: - # ruby-version: [2.3, 2.4, 2.5, 2.6, 2.7, jruby-9.2.7.0] - ruby-version: [2.3, jruby-9.2.7.0] + ruby-version: [2.3, 2.4, 2.5, 2.6, 2.7, jruby-9.2.16.0] steps: - uses: actions/checkout@v2 - name: Set up Ruby From 562c2bf323ddbc6ce8a927cc1b3d265dfca80290 Mon Sep 17 00:00:00 2001 From: Richard Marmorstein Date: Wed, 10 Mar 2021 14:32:23 -0500 Subject: [PATCH 08/10] No coveralls --- Gemfile | 1 - 1 file changed, 1 deletion(-) diff --git a/Gemfile b/Gemfile index 79d1c24a1..ab22a8a0e 100644 --- a/Gemfile +++ b/Gemfile @@ -5,7 +5,6 @@ source "https://rubygems.org" gemspec group :development do - gem "coveralls", require: false gem "mocha", "~> 0.13.2" gem "rack", ">= 2.0.6" gem "rake" From fe7bdece1672b92e8320d4cce2f8ae295b833663 Mon Sep 17 00:00:00 2001 From: Richard Marmorstein Date: Wed, 10 Mar 2021 14:34:30 -0500 Subject: [PATCH 09/10] Really, no coveralls --- README.md | 1 - test/test_helper.rb | 3 --- 2 files changed, 4 deletions(-) diff --git a/README.md b/README.md index 7ae0622a1..508dfe5ef 100644 --- a/README.md +++ b/README.md @@ -2,7 +2,6 @@ [![Gem Version](https://badge.fury.io/rb/stripe.svg)](https://badge.fury.io/rb/stripe) [![Build Status](https://travis-ci.org/stripe/stripe-ruby.svg?branch=master)](https://travis-ci.org/stripe/stripe-ruby) -[![Coverage Status](https://coveralls.io/repos/github/stripe/stripe-ruby/badge.svg?branch=master)](https://coveralls.io/github/stripe/stripe-ruby?branch=master) The Stripe Ruby library provides convenient access to the Stripe API from applications written in the Ruby language. It includes a pre-defined set of diff --git a/test/test_helper.rb b/test/test_helper.rb index 1f8be5dc3..b57d6c6e0 100644 --- a/test/test_helper.rb +++ b/test/test_helper.rb @@ -1,8 +1,5 @@ # frozen_string_literal: true -require "coveralls" -Coveralls.wear!("test_frameworks") - require "stripe" require "test/unit" require "mocha/setup" From c7580a69356989387775329796855b9a0d48211b Mon Sep 17 00:00:00 2001 From: Richard Marmorstein Date: Wed, 10 Mar 2021 14:47:18 -0500 Subject: [PATCH 10/10] Ruby 3 --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index e38ec7f26..b1a38a6f4 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -21,7 +21,7 @@ jobs: runs-on: ubuntu-latest strategy: matrix: - ruby-version: [2.3, 2.4, 2.5, 2.6, 2.7, jruby-9.2.16.0] + ruby-version: [2.3, 2.4, 2.5, 2.6, 2.7, 3.0, jruby-9.2.16.0] steps: - uses: actions/checkout@v2 - name: Set up Ruby