-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android: 3DS2 crashes #1387
Comments
It is 3DS2 that crashes. 3DS works fine. |
This is fixed now, but unfortunately will not work with Expo SDK 48 (unless you're able to use something like the dev client to upgrade your version of Stripe React Native). Otherwise, you'll have to wait for the next Expo SDK release |
Can you elaborate on
I have no idea what you mean by that. And why do we need to wait for another Expo release, isnt this constrain of Stripe React Native? |
Sure! Here are docs on the dev client: https://docs.expo.dev/develop/development-builds/introduction/
No, this is fixed in Stripe React Native. Expo would need to update their bundled version of this library to fix it in Expo Go |
We are not using Expo Go, we using custom built dev client and obviously production builds. Expo Go is just for toying around. The thing is that everywhere in docs it is written that we should be using this specific version of Stripe RN with Expo 48, I dont understand why. |
I'm not an Expo expert, but I believe if you're using a custom dev client, you aren't constrained to the specific versions associated with an Expo SDK. But maybe there are some expo docs that can confirm that |
I've just tested it and it crashes even if I use latest version of Stripe RN.
|
Can you share a reproducible demo? I'm not able to reproduce this crash in our test app |
Ah that's right! Sorry, I thought we had already released the update. That'll be addressed in the next release, early next week |
Well, Ill just go and ask. Can we do it sooner as in Europe and specially Czech Republic there are already banks running on 3DS2 and some of our customers cannot buy our services at this point? I'll even take a stretch and use a branch as dependency at this point :D |
Or a lower version where this is issue is not. |
@zdnk it looks like that crash was introduced after stripe/stripe-android#6603, which went out in android SDK v20.24.1. The most recent version of stripe-react-native only supports 20.24.0 (as you stated above), so I'm not sure how you're triggering this crash (unless the root cause of this crash is different). I tested this with the steps you shared above:
on v0.27.1, and I'm not getting a crash 🤔 FWIW, I used the 3ds2 test card: |
Would you share the repo please? I'll try it tomorrow and see if I can replicate it. One thing that occurred to me now, is that we have the whole thing in modal screen. But there aren't any special modifications or behaviors implemented. EDIT: just realized the modal presentation on Android is just regular screen/activity |
It's the example app in this repo: https://github.com/stripe/stripe-react-native/blob/master/example/src/screens/PaymentsUICompleteScreen.tsx |
Seems like the issue is fixed in the latest version. |
Describe the bug
When performing 3DS2 verification, app crashes on android.
To Reproduce
Expected behavior
everything works
Screenshots
Smartphone (please complete the following information):
Additional context
It seems like in android version this might have been fixed , but I am unable to use this version because Expo is locked to
"@stripe/stripe-react-native": "0.23.3"
which resolves to lower android sdk version I guess?The text was updated successfully, but these errors were encountered: