Using network retries causes client defined Idempotency Key to be over written

[prettyboymp]

When setting the idempotency_key option on a request, it gets overwritten if you are using network retries. The issue is being caused by a check for an existing Idempotency-Key in the headers array by key, however, the $headers array was already converted to a non-keyed array in ApiRequestor::_requestRaw().

Ref:

stripe-php/lib/HttpClient/CurlClient.php

Line 208 in 06c612b

if (!isset($headers['Idempotency-Key'])) {

Example:

\Stripe\Stripe::setMaxNetworkRetries( 2 );
\Stripe\Charge::create( $charge_parameters, [
  'api_key' => 'abcdefg',
  'idempotency_key' => '1234-5678-abcd-efg',
]);

The request getting sent to the API are getting a newly generated idempotency_key instead of the one manually set.

[ob-stripe]

Oops! Thanks for the report @prettyboymp, we'll work on a fix.

[ob-stripe]

Fixed in 6.34.2.