Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event Missing new Person Events "person.*" #627

Closed
virgofx opened this issue Apr 11, 2019 · 3 comments · Fixed by #628
Closed

Event Missing new Person Events "person.*" #627

virgofx opened this issue Apr 11, 2019 · 3 comments · Fixed by #628
Assignees

Comments

@virgofx
Copy link
Contributor

virgofx commented Apr 11, 2019

Looks like the Event class is missing some of the new event constants - specifically the person.* events.

PHP Stripe SDK: Master
PHP Version: 7.2

@remi-stripe
Copy link
Contributor

@virgofx Thanks for the heads up. I opened a PR to fix this: #628

@remi-stripe remi-stripe self-assigned this Apr 11, 2019
@virgofx
Copy link
Contributor Author

virgofx commented Apr 11, 2019

@remi-stripe While you're at it could you add the constants for the gender field?

    /**
     * Possible string representations of a person's gender.
     * @link https://stripe.com/docs/api/persons/object#person_object-gender
     */
    const GENDER_MALE = 'male';
    const GENDER_FEMALE = 'female';

The only other constants I could see adding for Person are those for the verification status field; however, there wasn't much information in the API docs. Would be nice to add those as well as a recent PR went through and added a bunch of constants making things much easier so the library is getting very feature complete in terms of available options/constants.

@ob-stripe
Copy link
Contributor

Fixed in 6.31.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants