Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request-Id is now lowercase #529

Closed
ruudk opened this issue Oct 8, 2018 · 3 comments
Closed

Request-Id is now lowercase #529

ruudk opened this issue Oct 8, 2018 · 3 comments

Comments

@ruudk
Copy link
Contributor

ruudk commented Oct 8, 2018

After upgrading from v6.10.0 to v6.19.1 I noticed that the Request-Id header does not exist anymore. Instead, you have to use request-id.

Why was this breaking change not documented and included in a new major?

@ob-stripe
Copy link
Contributor

Hi @ruudk, thanks for the report and sorry for the trouble. It turns out this was an unforeseen side-effect of enabling HTTP/2 in the library (cf. #494).

In HTTP/2, all headers are in lowercase. HTTP headers are supposed to be case-insensitive, but since the headers are copied in a regular PHP array, the keys are case-sensitive :/

We'll work on a fix and update here once it's released.

@ob-stripe
Copy link
Contributor

Fixed in 6.19.2. Headers can now be accessed regardless of case.

Feel free to reply here if you're still encountering issues after upgrading.

@ruudk
Copy link
Contributor Author

ruudk commented Oct 8, 2018

Thanks for the fast fix!! 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants