Skip to content

Commit

Permalink
Merge pull request #683 from stripe/remi-add-bt
Browse files Browse the repository at this point in the history
Move Balance History endpoint to /v1/balance_transactions
  • Loading branch information
remi-stripe authored Aug 1, 2019
2 parents a57cafe + ef4a71c commit 12c02ab
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 14 deletions.
3 changes: 1 addition & 2 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,7 @@ matrix:

env:
global:
- STRIPE_MOCK_VERSION=0.60.0

- STRIPE_MOCK_VERSION=0.63.0
cache:
directories:
- $HOME/.composer/cache/files
Expand Down
9 changes: 0 additions & 9 deletions lib/BalanceTransaction.php
Original file line number Diff line number Diff line change
Expand Up @@ -63,13 +63,4 @@ class BalanceTransaction extends ApiResource
const TYPE_TRANSFER_CANCEL = 'transfer_cancel';
const TYPE_TRANSFER_FAILURE = 'transfer_failure';
const TYPE_TRANSFER_REFUND = 'transfer_refund';

/**
* @return string The class URL for this resource. It needs to be special
* cased because it doesn't fit into the standard resource pattern.
*/
public static function classUrl()
{
return "/v1/balance/history";
}
}
4 changes: 2 additions & 2 deletions tests/Stripe/BalanceTransactionTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ public function testIsListable()
{
$this->expectsRequest(
'get',
'/v1/balance/history'
'/v1/balance_transactions'
);
$resources = BalanceTransaction::all();
$this->assertTrue(is_array($resources->data));
Expand All @@ -21,7 +21,7 @@ public function testIsRetrievable()
{
$this->expectsRequest(
'get',
'/v1/balance/history/' . self::TEST_RESOURCE_ID
'/v1/balance_transactions/' . self::TEST_RESOURCE_ID
);
$resource = BalanceTransaction::retrieve(self::TEST_RESOURCE_ID);
$this->assertInstanceOf("Stripe\\BalanceTransaction", $resource);
Expand Down
2 changes: 1 addition & 1 deletion tests/bootstrap.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

require_once(__DIR__ . '/StripeMock.php');

define("MOCK_MINIMUM_VERSION", "0.60.0");
define("MOCK_MINIMUM_VERSION", "0.63.0");

if (\Stripe\StripeMock::start()) {
register_shutdown_function('\Stripe\StripeMock::stop');
Expand Down

0 comments on commit 12c02ab

Please sign in to comment.