Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RequestOptions type does not include optional host parameter #1447

Closed
suby-stripe opened this issue Jun 9, 2022 · 1 comment · Fixed by #1448
Closed

RequestOptions type does not include optional host parameter #1447

suby-stripe opened this issue Jun 9, 2022 · 1 comment · Fixed by #1448
Labels

Comments

@suby-stripe
Copy link

Describe the bug

API request methods accept an optional host parameter in order to direct requests to a custom host, like:

stripe.files.create({...}, {host: "…"})

This is not included in the RequestOptions type.

To Reproduce

1: attempt to call a Stripe API method with an optional host parameter.
2!: Compilation fails due to lack of host paramter in the RequestOptions type.

Expected behavior

I would expect compilation to succeed with the host parameter.

Code snippets

Attempt to compile the following:


const verificationSession = await stripe.identity.verificationSessions.create(
    {
      type: 'document',
    },
    {host: "stripe.test.local"}
  );


### OS

macOS

### Node version

v14.18.1

### Library version

9.5.0

### API version

2020-08-27

### Additional context

_No response_
@remi-stripe
Copy link
Contributor

Thanks for the report, I'm working on a fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants