Metadata encoding issue with certain characters

[karlr-stripe]

As noted in #1374, if you attempt to create an object in the API with metadata with certain characters(such as #), it results in a malformed request. The API itself accepts these characters so it appears to be an issue with the library. The following code reproduces the problem:

var chargeOptions = new ChargeCreateOptions()
{
   Amount = 2000,
   Currency = "usd",
   SourceId = "tok_visa",
   Metadata = new Dictionary<string, string>{
      {"Invoice #", "42"}
    }
};

ChargeService chargeService = new ChargeService();

Charge charge = chargeService.Create(chargeOptions);
Assert.NotNull(charge);

request ID : req_TSGAWLekqimvqv

It looks like the raw POST data sent is :
amount=2000&currency=usd&metadata[Invoice%20
but it should be
source=tok_visa&amount=1000&currency=usd&metadata%5BInvoice%20%23%5D=42

I'm not sure what the cause here is, maybe the string interpolation?

[ob-stripe]

Thanks Karl. Looks like the key is not URL-encoded.

[ob-stripe]

Fixed in 20.4.1.