Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When submitting the form with errors, the first EditText with an error is not automatically focused. #1561

Closed
FrancoisBlavoet opened this issue Sep 17, 2019 · 3 comments · Fixed by #1564 or #2038
Closed

When submitting the form with errors, the first EditText with an error is not automatically focused. #1561

FrancoisBlavoet opened this issue Sep 17, 2019 · 3 comments · Fixed by #1564 or #2038
Assignees
@mshafrir-stripe
Labels
triaged Issue has been reviewed by Stripe and is being tracked internally

Comments

@FrancoisBlavoet
Copy link
Contributor

Summary

When submitting the form with errors, the first EditText with an error is not automatically focused.
This is an error reported to us by our a11y auditors
When one of the field is errored, ideally it should acquire focus but the stripe widgets do not

Code to reproduce

Just including the default stripe card input widgets.

Android version

Android 21, 25, 29

Impacted devices

Pixel 2, emulator, tester device (not sure)

Installation method

gradle include

SDK version

v11.0.5

Other information
mshafrir-stripe added a commit that referenced this issue Sep 17, 2019
@mshafrir-stripe
Move CardMultilineWidget focus to first error field on error
0195f6e 
Fixes #1561
@mshafrir-stripe mshafrir-stripe mentioned this issue Sep 17, 2019
Merged
@mshafrir-stripe mshafrir-stripe self-assigned this Sep 17, 2019
@mshafrir-stripe mshafrir-stripe added the triaged Issue has been reviewed by Stripe and is being tracked internally label Sep 17, 2019
mshafrir-stripe added a commit that referenced this issue Sep 17, 2019
@mshafrir-stripe
Move CardMultilineWidget focus to first error field on error (#1564)
17c5927 
Fixes #1561
@FrancoisBlavoet
Copy link
Contributor Author

😲
Thanks for the quick fix !

@FrancoisBlavoet
Copy link
Contributor Author

💯

@FrancoisBlavoet
Copy link
Contributor Author

Hi,
Unfortunately I am still encountering this error on the last release :
https://youtu.be/mo2U8v8kcUk
-> even though the input is incorrect (for example because the expiration date is in the past), I only get an error message and no focus change.

Can this also be fixed for CardInputWidget please ?

@mshafrir-stripe mshafrir-stripe mentioned this issue Jan 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mshafrir-stripe mshafrir-stripe

Labels
triaged Issue has been reviewed by Stripe and is being tracked internally
Projects
None yet
Milestone
No milestone
2 participants
@FrancoisBlavoet @mshafrir-stripe