[BUG] [PaymentSheet] Payment gets failed on back press.

[fbarthelery]

Summary

Similar to #5844 (I could not reopened), if user presses back button in the middle of processing, the PaymentSheetActivity may finish before processing complete and the result intent will not be set. PaymentSheetContract.parseResult() will then set a PaymentSheetResult.Failed while backend will get a confirmed payment.

stripe-android: 20.18.0

SDK classes

PaymentSheet, PaymentSheetActivity

Other information

I think the fix from #5848 has been lost with #6012.
From what I understand, BaseSheetActivity.onBackPressedCallback is only enabled when the viewmodel is not processing. So when you click the buy button, the translucent PaymentLauncherConfirmationActivity is launched and handle onBackPressed while confirming payment.
I think there is a small window after PaymentLauncherConfirmationActivity is destroyed, where BaseSheetActivity receives onBackPressed event and the onBackPressedCallback is not enabled.

[tillh-stripe]

HI @fbarthelery! Thanks for submitting this. We’ll take a look and see how we can fix this.

[jaynewstrom-stripe]

@fbarthelery this was fixed/released yesterday as https://github.com/stripe/stripe-android/releases/tag/v20.19.1

[fbarthelery]

👍 I cannot reproduce it on v20.19.1 Thanks