Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Resources are not namespaced to avoid colliding with custom resources. #4630

Closed
sjcqs opened this issue Mar 1, 2022 · 4 comments
Closed
Assignees
Labels

Comments

@sjcqs
Copy link

sjcqs commented Mar 1, 2022

Summary

Similar to #1656

The arrow in the 3DS ChallengeActivity are not prefixed.

Code to reproduce

  1. Create an app with a drawable called ic_arrow
  2. Open the 3DS screen (via PaymentLauncher or the PaymentSheet)
  3. The arrows are not the right ones (in the light theme, it's not colliding in the dark one)

Android version

Every versions

Impacted devices

Every devices

Installation method

Gradle

Dependency Versions

kotlin: 1.6.10 (should not have any impact)
stripe-android: 19.2.0
Android Gradle Plugin: 7.1.2
Gradle: 7.3.3

SDK classes

ChallengeActivity (I only tested this one, maybe other resources are missing a prefix)

Video

image

(obviously this icon is just to demonstrate the unwanted resource overriding issue)

@sjcqs sjcqs added the bug label Mar 1, 2022
@skyler-stripe skyler-stripe self-assigned this Mar 2, 2022
@skyler-stripe
Copy link
Contributor

Hey there. These live in our closed source 3ds2 repo. I've submitted a PR to rename the icons missing the stripe prefixes. The change should go out in the next release. I will update when status changes on the PRs.

@sjcqs
Copy link
Author

sjcqs commented Mar 3, 2022

Thanks you 👍

@skyler-stripe
Copy link
Contributor

The update to our 3ds2 sdk is merged. It will go out in the next release.

@skyler-stripe
Copy link
Contributor

Hey there,

This should be fixed in the latest release. Let us know if you're stilling having issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants