Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] CVC text does not hide in CardMultilineWidget #4292

Closed
litmon opened this issue Oct 14, 2021 · 2 comments · Fixed by #4309
Closed

[BUG] CVC text does not hide in CardMultilineWidget #4292

litmon opened this issue Oct 14, 2021 · 2 comments · Fixed by #4309
Assignees

Comments

@litmon
Copy link

litmon commented Oct 14, 2021

Summary

When I used CardMultilineWidget in my app, CVC text did not hide.

I think that it should be inputType = InputType.TYPE_CLASS_NUMBER or InputType.TYPE_NUMBER_VARIATION_PASSWORD.
https://github.com/stripe/stripe-android/blame/b283ba421a89756d22e9ed986b9bc249e7adcfad/payments-core/src/main/java/com/stripe/android/view/CvcEditText.kt#L46

It pointed out by #2897 (comment) , but it's not.

Code to reproduce

Android version

Impacted devices

Installation method

Dependency Versions

kotlin: 1.5.30
stripe-android: 17.2.0
Android Gradle Plugin: 7.0.0
Gradle: 7.0.2

SDK classes

CardMultilineWidget
CvcEditText

Video

Other information

@michelleb-stripe
Copy link
Contributor

@litmon We will take a look

@michelleb-stripe
Copy link
Contributor

@litmon The CVC digits are not hidden like a password would be by design. Any non-numeric characters entered on the software keyboard are ignored.

However, we have implemented a fix so that the number pad that is brought up only contains numbers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants