You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
and it appears to be failing spectacularly for apiGroups like rbac.authorization.k8s.io and so on because authorization.k8s.io part is not actually encoded anywhere in generated proto packages.
I'm thinking to pass this via proto.package (perhaps, proto.k8s_package) import definitions instead via additional argument and store groupVersion info inside skyProtoMessage.
Opening as issue first to discuss since this implies an api change.
The text was updated successfully, but these errors were encountered:
I don't think we want to add Kubernetes API group directly into the protobuf handling, but it might be worth adding a skycfg/kubernetes package to hold all this k8s-specific magic. Given how irregular the Kubernetes API group names are, it might require a hardcoded lookup table to fully implement gvkFromMsgType().
I don't think we want to add Kubernetes API group directly into the protobuf handling, but it might be worth adding a skycfg/kubernetes package to hold all this k8s-specific magic
👍 I'll sketch out some interfaces and send a wip pr.
Given how irregular the Kubernetes API group names are, it might require a hardcoded lookup table...
This is basically what I'm trying to avoid by having the user do all the hardcoding =)
So I tried to write more involved Kubernetes definitions using similar code in
skycfg/_examples/k8s/main.go
Lines 120 to 132 in f62bbbf
rbac.authorization.k8s.io
and so on becauseauthorization.k8s.io
part is not actually encoded anywhere in generated proto packages.I'm thinking to pass this via
proto.package
(perhaps,proto.k8s_package
) import definitions instead via additional argument and store groupVersion info insideskyProtoMessage
.Opening as issue first to discuss since this implies an api change.
The text was updated successfully, but these errors were encountered: