Add component for payButton element #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awalker-stripe
force-pushed
the
awalker/add-pbe
branch
from
189e1c4 to
e399bfa
Compare
jackieosborn-stripe
previously approved these changes
Nov 14, 2022
| @@ -10,6 +10,7 @@ import { | |||
| PaymentRequestButtonElementComponent, | |||
| CartElementComponent, | |||
| } from '../types'; | |||
| import {PayButtonElement} from '..'; | |||
There was a problem hiding this comment.
Should we instead do import PayButtonElementComponent in the above import line?
Comment on lines
554
to
572
| it('propagates the Element`s lineitemclick event to the current onConfirm prop', () => { | ||
| const mockHandler = jest.fn(); | ||
| const mockHandler2 = jest.fn(); | ||
| const {rerender} = render( | ||
| <Elements stripe={mockStripe}> | ||
| <PayButtonElement onConfirm={mockHandler} /> | ||
| </Elements> | ||
| ); | ||
| rerender( | ||
| <Elements stripe={mockStripe}> | ||
| <PayButtonElement onConfirm={mockHandler2} /> | ||
| </Elements> | ||
| ); | ||
|
|
||
| const confirmEventMock = Symbol('lineitemclick'); | ||
| simulateConfirm(confirmEventMock); | ||
| expect(mockHandler2).toHaveBeenCalledWith(confirmEventMock); | ||
| expect(mockHandler).not.toHaveBeenCalled(); | ||
| }); |
There was a problem hiding this comment.
Maybe an accidental copy-paste?
There was a problem hiding this comment.
oops, good catch, ty!
| /** | ||
| * Triggered when a buyer authorizes a payment within a supported payment method. | ||
| */ | ||
| onConfirm: (event: stripeJs.StripePayButtonElementConfirmEvent) => any; |
jackieosborn-stripe
approved these changes
Nov 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & motivation
Adds component for the
payButtonelement.Testing & documentation
Performed manual testing using a local React project.