Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Have a checkbox that allows you close the GUI when escaping from console #443

Closed
Jayinem opened this issue Oct 19, 2024 · 38 comments

Comments

@Jayinem
Copy link

Jayinem commented Oct 19, 2024

Using the --profile feature and autoconnect, with the addition of autohotkey scripts I've set it up where I can launch a console of my choice with just a keyboard key. It would be awesome if there was an option to not have the GUI come back up after I close the console, since I don't need the GUI at all unless I need to change a setting.

However I see the issue what if I needed to change a setting and it's all set to autoconnect I wouldn't be able to. Maybe either some type of keyboard shortcut or a separate .exe that only changes settings, but does not have the choice of other profiles.

@streetpea
Copy link
Owner

@Jayinem without the gui coming up there is no way to access the settings. This becomes a problem if you want to change the settings or access autoconnect.

@streetpea
Copy link
Owner

@Jayinem after thinking about it a little more I can add an argument for closing the app automatically via the command line. Then you could create a different shortcut without that argument or modify the shortcut as needed to access the settings

@Jayinem
Copy link
Author

Jayinem commented Oct 19, 2024

Thanks, yeah cause it's kind of a mess right now I'm accidentally turning on my other consoles while just controlling the one I want to control since you can use controller on the GUI.

Maybe another suggestion would be an option to only run one console at a time like the original Chiaki.

@streetpea
Copy link
Owner

Added --exit-app-on-stream-exit command to command line options which will close the GUI once you close the stream. Not sure what you mean by giving an option to run one console at a time. That is already an option in chiaki-ng. Just select a console and launch it If you want you can also make a profile with one console only registered.

@Jayinem
Copy link
Author

Jayinem commented Oct 20, 2024

Sorry I get confused.

I tried adding --exit-app-on-stream-exit to my chiaki shortcut but it gave me an error

chiaki: unknown option 'exit-app-on-stream-exit" this is my entire path

C:\Users\Jayinem\Documents\PS4\chiaki-ng-win_x64-VC-Release\chiaki.exe --profile=PS5 --exit-app-on-stream-exit

Or does this need to be implemented on the next chiaki-ng version that's not out yet?

@streetpea
Copy link
Owner

streetpea commented Oct 20, 2024

@streetpea streetpea reopened this Oct 20, 2024
@Jayinem
Copy link
Author

Jayinem commented Oct 20, 2024

I'm getting it now but one last thing.

I made 3 different folders one for each console, but when I go to consoles and delete the other 2 consoles that are there they still show up in the main screen even after deleting them they just show unregistered. How do I completely remove them?

@streetpea
Copy link
Owner

streetpea commented Oct 20, 2024

You can choose to hide the console in the menu

If you use autoconnect you will just launch into the correct console automatically see https://streetpea.github.io/chiaki-ng/setup/configuration/#auto-connect. Then you don’t even need to select the console in the menu

@Jayinem
Copy link
Author

Jayinem commented Oct 20, 2024

I got that but I'm having second thoughts on using --exit-app-on-stream-exit, the reason is for PS4 many times they don't connect on the first try only wake up the console but then I have to use the gui to select it a second time for it to actually load, I don't have this issue on PS5.

If I can have 3 separate chiakis one in each folder it might be ok for the gui to come back but I would want only the one console in the GUI hopefully. I'm not sure why I can't remove the other consoles.

I looked in appdata/roaming and there's only some logs, where is chiaki being stored that it's keeping up with whatever I do last because i go to different folders and make a change and it remembers what I did from the other folder and has the wrong profile.

@streetpea
Copy link
Owner

@Jayinem you need to hide the other consoles

@streetpea
Copy link
Owner

If you highlight the given unregistered console the option to hide it will appear

@Jayinem
Copy link
Author

Jayinem commented Oct 20, 2024

Ok got it i missed that, I think I'm all set. Thank you very much.

@streetpea
Copy link
Owner

streetpea commented Oct 20, 2024

I can update it to not quit on error if that helps, but it should retry on error already. Can you post a log on ps4 so I can see what’s happening? I don’t personally own a ps4 so can’t test on ps4

@Jayinem
Copy link
Author

Jayinem commented Oct 20, 2024

Strangely it's not doing it anymore all of my consoles are connecting on the first try now, and I looked at the logs they're all from the last few minutes it was happening a few hours ago so I wouldn't be able to post them when they were doing it.

I wonder if my GUI is showing up too big for my screen because I'm not seeing a hide button when I select a console, but since I made 3 different folders one for each console and am using your new build with the --exit-app-on-stream-exit command it's not as big of a deal anymore, only if it doesn't connect to the console will it show the GUI but mostly it's working.

@streetpea
Copy link
Owner

@Jayinem my bad, the hide consoles feature wasn't in the build I gave you. Try this build: https://github.com/streetpea/chiaki-ng/actions/runs/11423276566/artifacts/2078555114 hide should be an option now when you highlight a given unregistered console.

@Jayinem
Copy link
Author

Jayinem commented Oct 20, 2024

Ok I'll do that and just thought I'd let you know I just got timed out waiting for console, but it worked 2nd time.

[2024-10-20 10:34:31:645645] [I] Logging to file C:/Users/Jayinem/AppData/Roaming/Chiaki/Chiaki/log/chiaki_session_2024-10-20_10-34-31-640640.log
[2024-10-20 10:34:31:645645] [I] Chiaki Version 1.9.0
[2024-10-20 10:34:31:681681] [I] Trying to use hardware decoder "vulkan"
[2024-10-20 10:34:31:681681] [I] Using hardware decoder "vulkan" with pix_fmt=vulkan
[2024-10-20 10:34:31:689689] [I] ChiakiOpusEncoder initialized
[2024-10-20 10:34:31:690690] [I] Controller 0 opened: "Controller (MAGIC-NS) (0300bcb979000000d318000000007200)"
[2024-10-20 10:34:31:723723] [I] [libplacebo] Available surface configurations:
[2024-10-20 10:34:31:724724] [I] [libplacebo] 0: VK_FORMAT_B8G8R8A8_UNORM VK_COLOR_SPACE_SRGB_NONLINEAR_KHR
[2024-10-20 10:34:31:724724] [I] [libplacebo] 1: VK_FORMAT_B8G8R8A8_SRGB VK_COLOR_SPACE_SRGB_NONLINEAR_KHR
[2024-10-20 10:34:31:724724] [I] [libplacebo] 2: VK_FORMAT_R8G8B8A8_UNORM VK_COLOR_SPACE_SRGB_NONLINEAR_KHR
[2024-10-20 10:34:31:724724] [I] [libplacebo] 3: VK_FORMAT_R8G8B8A8_SRGB VK_COLOR_SPACE_SRGB_NONLINEAR_KHR
[2024-10-20 10:34:31:724724] [I] [libplacebo] 4: VK_FORMAT_A2B10G10R10_UNORM_PACK32 VK_COLOR_SPACE_SRGB_NONLINEAR_KHR
[2024-10-20 10:34:31:724724] [I] [libplacebo] Picked surface configuration 4: VK_FORMAT_A2B10G10R10_UNORM_PACK32 + VK_COLOR_SPACE_SRGB_NONLINEAR_KHR

@Jayinem
Copy link
Author

Jayinem commented Oct 20, 2024

Can you tell me why when I make changes to one folder it make changes to the other folders without me doing anything? I have a folder on one of my PS4s I tried hiding PS5 and another PS4, but when I open PS5 now I can't find PS5. It's not even there in consoles. And it seemed to change my default.ini. Is there a central location where these changes are being made? I don't see anything in appdata roaming just logs.

I now have 3 consoles that are registered, but can't be unregistered as they show up in the GUI but they don't show up under consoles under my PS5 folder. That doesn't make sense. And since nothing shows up under consoles I can't change autoconnect settings.

And how would I unhide because despite having a hidden console under hidden consoles it shows nothing.

@Jayinem
Copy link
Author

Jayinem commented Oct 20, 2024

Look at this 3 consoles that are ready
Untitled

But under consoles, 0 show up

Untitled2

@streetpea
Copy link
Owner

For windows settings are stored in the windows registry and each profile has its own registry entry .. you can see them with windows registry editor (there are no files locally on your computer)

@streetpea
Copy link
Owner

@Jayinem Do the registered consoles show up with the old build?

@streetpea
Copy link
Owner

@Jayinem I’ll look into it

@Jayinem
Copy link
Author

Jayinem commented Oct 20, 2024

Also hide does not always work.

No problem I'll wait.

I wish it would not touch the registry, it is causing a lot of issues for me even on older build I have no consoles now. I have no ability to unregister a console now.

I restored backups and was able to get them to show up under console again. Since I'm autoconnecting anyway I could just not worry about the other consoles showing up if the GUI shows up.

@streetpea
Copy link
Owner

@Jayinem it was a regression with the latest build I gave you. It's fixed here: https://github.com/streetpea/chiaki-ng/actions/runs/11452325499/artifacts/2085763488

@Jayinem
Copy link
Author

Jayinem commented Oct 23, 2024

It's still screwed up because of using the registry and maybe you can't do anything about that I don't know but as I mentioned i made 3 different folders I wanted to keep all 3 consoles separated where there's just one registered console for each folder but because you do it in the registry I went in and started unregistering consoles and now all my consoles are unregistered no matter if I try to use a backup .ini that was on my external hdd they're still not showing up in consoles and they show up in the main screen but not in consoles just like the pics I showed before. This is with the new build you gave me. The profiles are all screwed up. This would be simple if not for changing things in the registry which is permanent across the computer.

Not angry at you because you've done a lot of great work on this but just using the registry is causing an issue for me while it may not for other people. Admittedly I'm trying to do things most people won't like keyboard shortcuts and starting a specific console with controller shortcut.

And there's always one console I can hide but the other one it does not work. It just still sits there.

@streetpea
Copy link
Owner

streetpea commented Oct 23, 2024

@Jayinem using profiles separates them .. each profile has separate registry entries. When you launch a given profile and edit it, the other profiles remain unchanged.

@Jayinem
Copy link
Author

Jayinem commented Oct 23, 2024

Why does it have to be centralzed in the registry? Can you do a portable version? Trust me I tried for hours and it does not work right. And hide doesn't work either only on one console. I showed you earlier where there were 3 consoles registered with pictures that are proof and none in consoles that issue remains. There's all kinds of issues with this.

Or why not just have it where I can hide consoles without unregistering? Why do they need to be unregistered to hide them? Which doesn't work right anyway. Because it's unregistering them across the computer.

Since none of the consoles even show up under consoles I can't even autoconnect anymore. I'll have to start fresh and re-register them all tomorrow I'm going to sleep.

@streetpea
Copy link
Owner

streetpea commented Oct 23, 2024

It seems to work fine on my Steam Deck. I’ll try on a windows pc and get back to you regarding the profiles. It sounds like the profiles isn’t working on windows. Tbh I never tried hiding more than one console bc I only have 1 console. I didn’t give the ability to hide registered consoles bc why would you register a console if you didn’t want to use it. As I said already, consoles registrations are per profile so you just wouldn’t register the console on that profile. You just have to delete bc your importing all of the consoles to save time while normally you would register them manually. The real issue here is that the profiles don’t seem to be working for you with your shortcuts.

@streetpea
Copy link
Owner

You don’t have to re-register them. Just re-import the ini file you made

@Jayinem
Copy link
Author

Jayinem commented Oct 23, 2024

I'm kind of tired so I'm probably not explaning good, but what happens is ok I select PS5 profile, and autoconnect PS5 and unregister the other consoles. But then when I go to the other consoles profiles they're unregistered.

I'm not that stupid that I'm crazy and just making this up, I just need sleep I'll try it more tomorrow but hide stopped working on one console out of 2 which should be easy just hide them both but I click on hide or even hit square and the console still sits there. It's broken

You said yourself it hits the registry, that's computer wide not folder specific. That is the issue, but also hide not working on one specific PS4 console.

@Jayinem
Copy link
Author

Jayinem commented Oct 23, 2024

I tried one more time before I go to sleep here's the easiest way to explain it , just like the pictures I showed before I have 3 consoles in main screen now and none in consoles it doesn't matter which profile I import and I made multiple backups. None show in consoles. That should not be the case because I backed up profiles that were fully working and able to autoconnect, but it's the registry.

@streetpea
Copy link
Owner

streetpea commented Oct 23, 2024

@Jayinem I’ll set it up on my pc as you described and get it working on Windows (changing the code as necessary) Then I’ll get back to you with instructions and updated build that will definitely work. Sorry for the inconvenience.

@streetpea
Copy link
Owner

streetpea commented Oct 23, 2024

@Jayinem I was successful on my Windows 11 PC. I also found a few small bugs that I fixed in this build so please use this one: https://github.com/streetpea/chiaki-ng/actions/runs/11477762312/artifacts/2092840133

Since you mentioned having an ini file with all of your consoles registered, I started with that.
Then I made a copy of the ini file called profile1 and changed the this_profile setting from this_profile= (since it was the default profile I originally exported and I want the profile I import to be different [otherwise it will just overwrite my default profile instead of creating a new one like I intend]) to this_profile=profile1 (the new profile I wanted to import). I then imported profile1. Next, I changed the profile 1 ini file to make this_profile=PS5 and imported the ini again, now creating the PS5 profile. My Windows registry now looked like the following
WindowsRegistryChiakiProfiles with separate folders for each profile. Next, I changed the registered consoles on one profile and it didn't affect the other profiles. I then hid 2 consoles and they didn't show up anymore in discovery until I unhid them. I did find a bug though where focus would be lost and so the controller wouldn't be able to select the next entry. Maybe you didn't notice focus had been lost and you were trying to hide with a controller but it wasn't actually selected so it wasn't working. You can tell it doesn't have focus if when you are looking at the entry it says Hide but doesn't have the square button symbol next to it that you would use a controller for. It worked fine with a mouse on the old build but I fixed it in the new build so it works with a controller as well. Hopefully you can replicate this on your PC. Also you can see what your current profile is by looking at the window title which will have Chiaki-ng:profile if the profile is not default or Chiaki-ng if you are using the default profile. You can also see the currently active profile in the settings in the config section.

If you’re still having trouble lmk and I’ll make a video but if you follow what I did you should be golden and shouldn’t need to re-register anything (I didn’t need to on my windows device).

@Jayinem
Copy link
Author

Jayinem commented Oct 23, 2024

No it wasn't hiding it, I had focus I was moving with the controller between profiles, that's not what happened. It was hiding the PS5 no problem, but one of the PS4s seemed to be stuck no matter what I did or what profile I used.

But I just went back to the previous build without hiding because it's just causing me more issues than necessary. With this I am able to just run shortcuts and it doesn't matter if the other consoles aren't hidden because I'm autoconnecting. I was able to restore my previous consoles as well. I've tried multiple times now but every time I tried to start unregistering consoles I had issues. I'm not going to continue to try. But overall I'm extremely happy with chiaki-ng over the original. I've got PS5 set to Select + d-pad down, one PS4 set to Select + d-pad left and the other Select + d-pad right. I used autohotkey and joytokey I can just launch the consoles directly through my pc controller, something I could never do on the original chiaki.

I have one more question is there any way to take my PS5 offline yet still connect to Chiaki? Like with a certain DNS or anything? I am getting update nags and don't want to update my PS5.

@streetpea
Copy link
Owner

streetpea commented Oct 23, 2024

@Jayinem i can guarantee you are not setting up the profiles correctly and that is the root of your problem. If you follow the instructions I provided with the new build above (https://github.com/streetpea/chiaki-ng/actions/runs/11477762312/artifacts/2092840133) it will work as I tested it on my windows pc. Not sure about the hide not working though.

Did you change the this_profile= to the correct profile name before importing with the newest build?

@streetpea
Copy link
Owner

streetpea commented Oct 23, 2024

Just to clarify, as in the picture, each profile has its own folder in the registry so changing settings in one can’t affect a different profile because its settings exist in a different physical location. What you’re describing with the console being deleted from the other profiles is impossible if it’s set up correctly. This implies it’s not set up correctly because changing one registry value in a different folder doesn’t affect the registry value in another folder because they are distinct values. I think I am doing a poor job of explaining myself but maybe that makes sense along with the picture I posted above.

@streetpea
Copy link
Owner

streetpea commented Oct 23, 2024

@Jayinem If you send me a video of what you’re describing happening at [email protected] with the new build then I can tell you where you’re going wrong. Otherwise, I fear we will just talk in circles. I can post a video of what I’m doing if you don’t believe me but it works on my end in windows 11 following the steps I described with the newest build. Only takes a minute or 2 to set up.

@Jayinem
Copy link
Author

Jayinem commented Oct 23, 2024

Alright I'll try again later this evening with the latest build and your instructions and let you know when I can, I'm currently at work. Thank you for your help.

@streetpea
Copy link
Owner

Ok just try to go through and if it doesn't work lmk but I don't want you to continue wasting time on it bc I know that can be frustrating. To make sure you are in the right profile and everything you can always look at the title window which will say Chiaki-ng:profile_name or Chiaki-ng if on the default profile. The hide thing seems to definitely be a different bug based on what you were describing that for some reason doesn't happen with the ps5s I tried to hide but just make sure the build doesn't fix it anyway. I would like to fix it if there is an issue with it but as you mentioned for your use case it's probably not that important if you are just using autoconnect and quitting after stream or on stream failure bc in that case you should never see the gui

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants