Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make addr:housenumber appear earlier on the map, especially for object-related quests #6010

Closed
chrt223 opened this issue Nov 15, 2024 · 11 comments

Comments

@chrt223
Copy link

chrt223 commented Nov 15, 2024

Use case
Most quests about objects depends on precise placement, a in many case, the street number is a very good hint for precise placement (especially if a GPS is not available).

#6009 makes is even more significant since many artifacts related to buildings/entrance (like camera) are positioned near the street number.

Proposed Solution
Provide an option to display street numbers when doing object-related quests.

@matkoniecz
Copy link
Member

Do you mean addr:housenumber ?

@chrt223
Copy link
Author

chrt223 commented Nov 15, 2024

Exactly

@matkoniecz
Copy link
Member

I am pretty sure these are displayed, at least when you zoom in. Can you show example of not displayed one?

@matkoniecz matkoniecz added the feedback required more info is needed, issue will be likely closed if it is not provided label Nov 15, 2024
@chrt223
Copy link
Author

chrt223 commented Nov 16, 2024

https://www.openstreetmap.org/node/2709957324

address mode

address-quest

object quest

object-quests

@mnalis
Copy link
Member

mnalis commented Nov 16, 2024

And do the housenumbers appear if you zoom-in more, @chrt223 ?

@chrt223
Copy link
Author

chrt223 commented Nov 16, 2024

And do the housenumbers appear if you zoom-in more, @chrt223 ?

Oh, so true!

But these are shown only if screen view covers less than 25m.
Problem is that many areas, housenumbers don't exist and interpolation was used to determine first/last numbers for blocks of 100m x 100m (it's been done for entire cities, without addr:inclusion a decade ago).

These first/last housenumbers serve as an indicator of distance aren't available if you want to add an object at the middle of the block (either they don't appear due to insufficient zoom level, either they are outside the view).

=> In area were parcels of 10m to 20m are not uncommon, showing housenumbers at a 200m screen-view zoom-level would be saner (at least for some quests and in some areas)

@matkoniecz
Copy link
Member

Maybe it is one more unintentional effect of "zoom levels have different meaning in new map renderer"

@matkoniecz matkoniecz changed the title display street numbers for object-related quests make addr:housenumber appear earlier on the map, especially for object-related quests Nov 16, 2024
@mnalis
Copy link
Member

mnalis commented Nov 17, 2024

[...] as an indicator of distance aren't available

@matkoniecz matkoniecz removed the feedback required more info is needed, issue will be likely closed if it is not provided label Nov 17, 2024
@westnordost
Copy link
Member

So, I checked, and indeed with the maplibre style, the housenumbers appeared exactly one zoom level later than with the tangram style. I changed it so that it matches the previous behavior.

@chrt223
Copy link
Author

chrt223 commented Dec 16, 2024

Still not quite that.
It's an improvement, but even at this zoom level, housenumbers still appear too late (using the latest v60.0 version) :

Less than 100m per screen-height, and still no visible house number:
nonum

Below ~80m, they (finally) appear:

num

... but it's too late.

Whatever the magic distance is, , it's should be > 110m (with a margin of error)

Because placing an object in front of StreetName 1035 when only 1001 and 1999 are visible already implies some approximation (We'd need a dynamic ruler to evaluate distance between two points). But if one of the 1001 or the 1099 marks isn't visible, it's unacceptably imprecise.

@matkoniecz
Copy link
Member

See streetcomplete/maplibre-streetcomplete-style#2 - it still needs rebuild, merging into new release and being released and updating phone app before you will see it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants