Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "display order" from quest selection title #5833

Closed
FloEdelmann opened this issue Aug 22, 2024 · 1 comment
Closed

Remove "display order" from quest selection title #5833

FloEdelmann opened this issue Aug 22, 2024 · 1 comment
Labels
wontfix idea rejected because it is out of scope or because required work is not matching expected benefits

Comments

@FloEdelmann
Copy link
Member

In #5719, the quest reordering functionality was removed:

Reordering quests with drag & drop is no longer supported because this is a missing feature in compose so far

However, the setting is still called "Quest selection and display order" (emphasis mine). Since this is not possible anymore, the setting should be renamed to just "Quest selection".

Or is it supposed to come back later? But even then, it should be renamed in the meantime because it is confusing.

@westnordost
Copy link
Member

Yes, maybe it can come back later. See this comment in the code. https://github.com/streetcomplete/StreetComplete/blob/master/app/src/main/java/de/westnordost/streetcomplete/screens/settings/quest_selection/QuestSelectionScreen.kt#L34-L39

I don't want to change the strings while the situation may change soon.

@westnordost westnordost closed this as not planned Won't fix, can't repro, duplicate, stale Aug 22, 2024
@westnordost westnordost added the wontfix idea rejected because it is out of scope or because required work is not matching expected benefits label Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix idea rejected because it is out of scope or because required work is not matching expected benefits
Projects
None yet
Development

No branches or pull requests

2 participants