Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't ask if path crosses barrier if the path *is* the barrier #5438

Closed
osmuser63783 opened this issue Jan 10, 2024 · 4 comments
Closed

Don't ask if path crosses barrier if the path *is* the barrier #5438

osmuser63783 opened this issue Jan 10, 2024 · 4 comments
Labels

Comments

@osmuser63783
Copy link

Browsing through notes I just noticed a small issue where the quest how the path crosses the barrier was asked where it shouldn't be:
https://www.openstreetmap.org/note/3680127
https://www.openstreetmap.org/note/3680126

I suspect this is because the way https://www.openstreetmap.org/way/199858771 is tagged highway=footway and barrier=city_wall. As a result SC asks the quest on every node of the way.

Not sure how common this kind of double tagging is.

How to Reproduce
Look at Chester city walls:
Screenshot_20240110_212838_StreetComplete

Expected Behavior
Don't ask the quest.

Versions affected
Originally reported in v52, still an issue in v56.0

@matkoniecz
Copy link
Member

@osmuser63783

Thanks for reporting, current behaviour makes no sense and this tagging, while I would not use it, seems to not be clearly wrong.

@matkoniecz
Copy link
Member

Also, this bug report is an excellent example of following rules described in https://www.chiark.greenend.org.uk/~sgtatham/bugs.html

@osmuser63783
Copy link
Author

Wow, that was quick. Thank you!

@matkoniecz
Copy link
Member

Note that change is not yet deployed: that requires making a new release and this bug is not big enough (see JOSM bug that in one old version swapped longitude and latitude on edit...) to justify making emergency one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants