Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Database interface on iOS #5417

Open
westnordost opened this issue Dec 20, 2023 · 1 comment
Open

Implement Database interface on iOS #5417

westnordost opened this issue Dec 20, 2023 · 1 comment
Assignees
Labels
iOS necessary for iOS port

Comments

@westnordost
Copy link
Member

westnordost commented Dec 20, 2023

Requires #5412.

Implement the Database.kt interface for iOS using libsqlite3, analogous to android-specific implementation in AndroidDatabase

Currently, the code that creates the database file if it does not exist yet and opens the database in a thread-safe way is done StreetCompleteSQLiteOpenHelper (that inherits functionality from the Android class SQLiteOpenHelper. This functionality either needs to be reimplemented in platform-independent code or be reimplemented on iOS side.

@westnordost westnordost added blocked blocked by another issue iOS necessary for iOS port labels Dec 20, 2023
@westnordost westnordost moved this to Blocked in iOS Port Dec 20, 2023
@westnordost
Copy link
Member Author

westnordost commented Jan 8, 2025

Note: https://developer.android.com/kotlin/multiplatform/sqlite is a multiplatform sqlite library, which may remove the necessity to implement Database on iOS separately.

It is multiplatform-capable since v2.5.0, which has been in alpha since May 2014 (as of 2025-01-08, it is at alpha 12)

(Not blocked anymore because this could be implemented right away, without the need to setup the project as multiplatform)

@westnordost westnordost removed the blocked blocked by another issue label Jan 8, 2025
@westnordost westnordost moved this from Blocked to Todo in iOS Port Jan 8, 2025
@FloEdelmann FloEdelmann self-assigned this Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iOS necessary for iOS port
Projects
Status: Todo
Development

No branches or pull requests

2 participants