Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ask for phone/website/email for shops #2839

Open
5 tasks done
TurnrDev opened this issue May 3, 2021 · 10 comments
Open
5 tasks done

Ask for phone/website/email for shops #2839

TurnrDev opened this issue May 3, 2021 · 10 comments

Comments

@TurnrDev
Copy link
Contributor

TurnrDev commented May 3, 2021

General

Affected tag(s) to be modified/added:
Question asked: What is the phone number for XYZ?

Checklist

Checklist for quest suggestions (see guidelines):

  • 🚧 To be added tag is established and has a useful purpose
  • 🤔 Any answer the user can give must have an equivalent tagging (Quest should not reappear to other users when solved by one)
  • 🐿️ Easily answerable by everyone from the outside but a survey is necessary
  • 💤 Not an overwhelming percentage of elements have the same answer (No spam)
  • 🕓 Applies to a reasonable number of elements (Worth the effort)

Quite often shops and businesses will list their number on the front, along with sometimes fax, email and website. I'm surprised this isn't already included.

Similar to opening times, we can use *:signed=no if no number/email/website is on the sign, preventing the quest from being shown again for x amount of time.

@matkoniecz
Copy link
Member

See https://github.com/streetcomplete/StreetComplete/wiki/Adding-new-Quests-to-StreetComplete

Especially

For example, a quest that asks for the website of a place must be able to tag the element somehow if the user answers that the place has no website - otherwise, the next user will be asked the same question. Sometimes, due to the nature of how things are tagged in OSM (such as the one given in the example) it is unfortunately simply not possible to fulfill this

@TurnrDev
Copy link
Contributor Author

TurnrDev commented May 3, 2021

Surely the *:signed=no solution that worked for opening_hours would work here?

@HolgerJeromin
Copy link
Contributor

ref #2043

@TurnrDev
Copy link
Contributor Author

TurnrDev commented May 3, 2021

ref #2043

Thank you, good read! I'm gonna close this for now. Might be time a generic *:signed suffix tag is proposed on the wiki, I'll talk to people and get a consensus of if it's worth it.

@TurnrDev TurnrDev closed this as completed May 3, 2021
@tiptoptom
Copy link
Contributor

Might be time a generic *:signed suffix tag is proposed on the wiki, I'll talk to people and get a consensus of if it's worth it.

@TurnrDev do you have any news on this?

@TurnrDev
Copy link
Contributor Author

TurnrDev commented Jul 1, 2021

I forgot to message about it 🤣

@ItsVipra
Copy link

Hiya, it's been a while since the last comment in this issue, and it seems the main problem holding it back has been resolved now. (Albeit a new tagging method is being proposed).

Would it be possible to take another look at this?

@flipflop97
Copy link

@TurnrDev Would you be ok with re-opening this given that the *:signed-suffix exists?

@TurnrDev
Copy link
Contributor Author

TurnrDev commented Jan 9, 2025

It's been 4 years, and my interest in this has dwindled, but I will reopen it.

@TurnrDev TurnrDev reopened this Jan 9, 2025
@mnalis
Copy link
Member

mnalis commented Jan 10, 2025

We would still need some other info as mentioned in #2043 (comment) :

Also, when we'd actually implement this, we'd need a list of places where it makes sense to ask. For example it will probably not be worth to ask for kiosks and convenience stores, but for hotels and other types of shops it would.

Also, people following this issue might be interested to know to SCEE (StreetComplete "Expert edition" fork) had both phone and website quests implemented for some time -- but they do allow user to modify the elementSelection, so it is not as important to get it right. It might be useful as a starting point though, e.g.:

https://github.com/Helium314/SCEE/blob/a8c5226492fbfc755a0f4ec7d213bc5aaa115073/app/src/main/java/de/westnordost/streetcomplete/quests/contact/AddContactWebsite.kt#L17

and

https://github.com/Helium314/SCEE/blob/a8c5226492fbfc755a0f4ec7d213bc5aaa115073/app/src/main/java/de/westnordost/streetcomplete/quests/contact/AddContactPhone.kt#L44-L61

Any more suggestions @flipflop97 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants