Bug in Themes

[tintinmaster]

When the System Theme differs from the selected them in the App (also in Auto mode) some elements have the theme background, but the wrong text color. So it's hard/impossible to read.
Using theme "System Default" works flawless.

It does not happen while changing the theme and a restart does not help, so it is not directly related to the other issues (which are all closed by now)

It seems like some backgrounds are always determined by the system theme and not by the theme the app enforces.

How to Reproduce
Have System Dark Mode activated and in-app Light theme activated or
Have System Dark Mode deactivated and in-app Dark theme activated

Versions affected
v24.1 and Android 10
Black System and Light In-App:

Light System and Dark In-App:

[westnordost]

I don't have a new phone so I do not have dark mode to reproduce it. Help would be appreciated.

[ENT8R]

I'm also on Android 10 and just tried whether I could reproduce any similar behaviour, but this is the only thing I noticed which comes close to the issue described above:

Seems weird to me that it differs that much across different devices, maybe it's the vendor's fault because they screwed something up in their dark mode implementation?

[matkoniecz]

I don't have a new phone so I do not have dark mode to reproduce it. Help would be appreciated.

I just (accidentally and with no clear info how to repeat, but may be related to opening phone during night after it was closed during day) reproduced it in Android 10 emulator, app had a default settings

[tintinmaster]

To clarify, I use a Huawei Phone, but still with Android and EMUI 10.1.0.
Tried it on an emulated Pixel 3a and everything worked fine.

Does anybody know any other apps, that are developed with Android Studio and have own themes, so I could test, if it has something to do with the vendors implementation?

[michaelblyons]

FWIW, I have a physical Pixel 3a. I've never seen any of the "bad" variants. My Android system is set to dark mode, and all four of the StreetComplete theme options work as expected.

[jleedev]

Here's another issue with blue text on a dark background

[smichel17]

I have a reliable repro for a similar bug in an Android 10 (api 29) emulator.

Steps:

• Stock Android emulator settings, clean install (no system dark theme)
• Open SC > Settings > Dark theme
• Click home button to minimize SC.
• App drawer > Long press on SC > App info > Storage & cache > Clear storage
• Return to home screen > app drawer > open SC > click through walkthrough > Open main menu

I wasn't able to reproduce theme weirdness anywhere other than the main menu (that I noticed). Closing the app, swiping it away in the recent apps list, and then re-opening fixes it.

---

Obviously this is an edge case that I wouldn't really expect us to handle, but perhaps the repro will help figure out the problem.

[Helium314]

I had this yesterday when theme was on auto (switched from light to dark).
Wasn't able to reproduce it with manual switch, but got a crash when switching from auto (light) to system default (dark):

Thread: DefaultDispatcher-worker-1
App version: 32.0-alpha1
Device: samsung serranods, Android 9
Locale: en_GB
Stack trace:
java.lang.RuntimeException: Tried to perform an operation on an invalid pointer! This means you may have used a MapData that has already been removed.
at com.mapzen.tangram.MapData.checkPointer(MapData.java:98)
at com.mapzen.tangram.MapData.setFeatures(MapData.java:36)
at de.westnordost.streetcomplete.map.components.PinsMapComponent.showPins(PinsMapComponent.kt:48)
at de.westnordost.streetcomplete.map.QuestPinsManager.updatePins(QuestPinsManager.kt:166)
at de.westnordost.streetcomplete.map.QuestPinsManager.access$updatePins(QuestPinsManager.kt:20)
at de.westnordost.streetcomplete.map.QuestPinsManager$updateQuestsInRect$2.invokeSuspend(QuestPinsManager.kt:129)
at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:106)
at kotlinx.coroutines.scheduling.CoroutineScheduler.runSafely(CoroutineScheduler.kt:571)
at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.executeTask(CoroutineScheduler.kt:750)
at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.runWorker(CoroutineScheduler.kt:678)
at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.run(CoroutineScheduler.kt:665)

Of course not reproducible, as usual.
SC was downloading/generating quests when the crash occurred... so I guess it's either connected to the theme bug here, or to switching theme at the "right" point of a download.

[bogomil]

If it's worth mentioning I can't reproduce the problem on a real device.
UI: 5.1
Android 13
SC version: 57.1

Steps:

• Have System Dark Mode activated and in-app Light theme activated
• Clicked on the Working hours challenge
• Then on the "Other Answers"
• I can see clearly the copy

I also tested my profile view - it works as it should be!

I run this on the simulator with:
Pixel 6a API VanillaIceCream

Same scenario
Cannot reproduce as well.

[westnordost]

Hm well, I don't think it is worthwhile to investigate this issue further, as we are in the process of migrating to a different UI framework anyway, for me at least. With a different UI framework come different bugs.

[westnordost]

So I am going to close this, because this bug won't be fixed anymore. Can be re-reported in case this happens in the new UI. Parts of the app currently already migrated to the new UI framework (on dev branch):

• Everything except the main screen
• all controls, dialogs, sidebars, dropdowns etc you see on the main screen

Anything that is shown in the bottom sheet (quests etc) is not migrated yet.