Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update istio values tftpl file #56

Merged
merged 1 commit into from
Apr 11, 2023
Merged

fix: update istio values tftpl file #56

merged 1 commit into from
Apr 11, 2023

Conversation

maxsxu
Copy link
Member

@maxsxu maxsxu commented Apr 11, 2023

Motivation

Comments in tftpl file should be # and file suffixed with .tftpl

@maxsxu maxsxu requested a review from ignacioli April 11, 2023 09:51
@maxsxu maxsxu requested a review from a team as a code owner April 11, 2023 09:51
@maxsxu maxsxu self-assigned this Apr 11, 2023
@maxsxu maxsxu merged commit 269dd96 into master Apr 11, 2023
@delete-merged-branch delete-merged-branch bot deleted the max/fix-tftpl branch April 11, 2023 10:03
@maxsxu maxsxu mentioned this pull request Apr 11, 2023
Merged
@github-actions github-actions bot mentioned this pull request Jul 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ignacioli ignacioli ignacioli approved these changes

Assignees

@maxsxu maxsxu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxsxu @ignacioli