Enable passing of custom AMI and userdata.sh for Node Groups #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdmaguire
reviewed
Jun 29, 2022
| variable "external_dns_helm_chart_name" { | ||
| default = "external-dns" | ||
| description = "The name of the Helm chart in the repository for ExternalDNS." | ||
| type = string | ||
| } | ||
|
|
||
| variable "external_dns_helm_chart_repository" { | ||
| default = "https://charts.bitnami.com/bitnami" | ||
| default = "https://raw.githubusercontent.com/bitnami/charts/eb5f9a9513d987b519f0ecd732e7031241c50328/bitnami" |
There was a problem hiding this comment.
I see you have this because 5.5.2 got trimmed.
An alternative would be to changing this would be to change external_dns_helm_chart_version to 6.5.5.
I'm fine with only the chart repo URL bump; I have a bias towards updating dependencies.
There was a problem hiding this comment.
Relevant SN issue about this pain: https://github.com/streamnative/cloud-ops/issues/285
There was a problem hiding this comment.
@jdmaguire I agree, we should probably just get a separate PR put together that uses newer versions of cert-manager and external-dns (both of those use the bitnami helm registry).
jdmaguire
previously approved these changes
Jun 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR enables the use of a custom AMI and
userdata.shto be used by the managed node group(s).Modifications
Added the following new inputs to the module:
func_pool_ami_idfunc_pool_ami_is_eks_optimizedfunc_pool_pre_userdatanode_pool_ami_idnode_pool_ami_is_eks_optimizednode_pool_pre_userdataVerifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
Documentation
Check the box below.
Need to update docs?
doc-required(If you need help on updating docs, create a doc issue)
no-need-doc(Please explain why)
doc(If this PR contains doc changes)