Initial commit of istio refactor #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EronWright
approved these changes
Jan 3, 2022
| @@ -96,7 +96,7 @@ resource "helm_release" "external_dns" { | |||
| repository = var.external_dns_helm_chart_repository | |||
| timeout = 300 | |||
| version = var.external_dns_helm_chart_version | |||
|
|
|||
There was a problem hiding this comment.
The external_dns module should depend on the istio module, since it relies on the CRDs.
There was a problem hiding this comment.
We can't add a dependency to Istio if it's an optional plugin (i.e. Platform use case).
There was a problem hiding this comment.
I suppose that the dependency between external_dns and istio modules would need to be expressed in the aggregated module, that I believe should be prescriptive.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: https://github.com/streamnative/cloud-api-server/issues/800
This refactor removes the locally sourced Istio Operator helm chart in favor of of the recently re-worked Istio configuration stored in the
streamnative/terraform-helm-chartsrepo.