Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[addons] Changed addon helm config format to native HCL data object #35

Merged
merged 4 commits into from
Dec 18, 2021

Conversation

jrsdav
Copy link
Contributor

@jrsdav jrsdav commented Dec 8, 2021

This is a mostly cosmetic change where we're standardizing on how we pass values to helm_release. Other changes are detailed below.

Previously this was done through a number of set {} value blocks, which is pretty rigid in terms of data types (lists, for instance, require some ugly hacks in HCL).

The better approach that we've found is to define a complex type, and pass that to the values = [] input with yamlencode(). We'll continue this pattern in other modules and make it the standard going forward.

Other changes in this PR include:

  • Updated default Kubernetes version for EKS from 1.18 to 1.20
  • Chart version defaults for minor updates
  • Creates a Calico CR when the Tigera operator is enabled and installed

@jrsdav jrsdav requested a review from EronWright December 8, 2021 19:04
@jrsdav
Copy link
Contributor Author

jrsdav commented Dec 18, 2021

Enabling the calico CR introduces some network connectivity problems on workloads within the cluster.

It's still undetermined if we will be using Calico for advanced network policies now that we're using Istio.

I have disabled Calico installing by default for the time being until this can be addressed.

@jrsdav jrsdav merged commit a15b4cb into master Dec 18, 2021
@delete-merged-branch delete-merged-branch bot deleted the imp/addon_config branch December 18, 2021 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant