[addons] Changed addon helm config format to native HCL data object #35
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a mostly cosmetic change where we're standardizing on how we pass values to
helm_release
. Other changes are detailed below.Previously this was done through a number of
set {}
value blocks, which is pretty rigid in terms of data types (lists, for instance, require some ugly hacks in HCL).The better approach that we've found is to define a complex type, and pass that to the
values = []
input withyamlencode()
. We'll continue this pattern in other modules and make it the standard going forward.Other changes in this PR include: