[addons] Install addons in kube-system #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ongoing work of bringing Istio support to this module has highligted the need for installing cluster specific addons into the kube-system namespace instead of sn-system. In the future, sn-system will be reserved for StreamNative components, such as our operators and Istio itself.
EronWright
approved these changes
Dec 6, 2021
| @@ -102,7 +102,7 @@ resource "helm_release" "cert_manager" { | |||
| chart = var.cert_manager_helm_chart_name | |||
| cleanup_on_fail = true | |||
| name = "cert-manager" | |||
| namespace = kubernetes_namespace.sn_system.id | |||
| namespace = "kube-system" | |||
There was a problem hiding this comment.
While it makes sense to install cert-manager into kube-system, any ClusterIssuer or Certificate that we create should be into sn-system. Is that still the case?
There was a problem hiding this comment.
Yep, that will still be the case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ongoing work of bringing Istio support to this module has highligted the need for installing cluster specific addons into the
kube-systemnamespace instead ofsn-system. This PR addresses this by changing the namespace for the Helm deployments accordingly.In the future,
sn-systemwill be reserved for StreamNative components, such as our operators and Istio itself.