fix: restrict cluster iam role name prefix length #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciiiii
reviewed
Dec 11, 2024
ciiiii
approved these changes
Dec 11, 2024
maxsxu
pushed a commit
that referenced
this pull request
Dec 12, 2024
🤖 I have created a release *beep* *boop* --- ## [4.1.2](v4.1.1...v4.1.2) (2024-12-12) ### Bug Fixes * restrict cluster iam role name prefix length ([#150](#150)) ([8c50e1f](8c50e1f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
IAM Role name length is between 1 and 64.
The IAM Role name_prefix length is between 1 and 38. Because the suffix length is 26 which is defined in the terraform provider.
Modifications
${var.cluster_name}-clusterto 37, since the separator-is 1Verifying this change
Documentation
no-need-doc