Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add module for dns and bucket #145

Merged
merged 2 commits into from
Nov 20, 2024
Merged

feat: add module for dns and bucket #145

merged 2 commits into from
Nov 20, 2024

Conversation

maxsxu
Copy link
Member

@maxsxu maxsxu commented Nov 15, 2024

Motivation

For support StreamNative Cloud.

Modifications

  • Add new submodule for creating dns zone and s3 bucket

It will backport as v3.4.0 in https://github.com/streamnative/terraform-aws-cloud/tree/release/v3.4.0

Verifying this change

  • Verified

Documentation

  • doc

Copy link
Contributor

@maxsxu:Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

@github-actions github-actions bot added the doc-info-missing This pr needs to mark a document option in description label Nov 15, 2024
@maxsxu maxsxu marked this pull request as ready for review November 18, 2024 09:12
@maxsxu maxsxu requested a review from a team as a code owner November 18, 2024 09:12
@github-actions github-actions bot removed the doc-info-missing This pr needs to mark a document option in description label Nov 18, 2024
Copy link
Contributor

@maxsxu:Thanks for providing doc info!

@github-actions github-actions bot added the doc This pr contains a document label Nov 18, 2024
@maxsxu maxsxu merged commit 8b7202b into master Nov 20, 2024
6 checks passed
@maxsxu maxsxu deleted the max/dns-bucket branch November 20, 2024 03:24
maxsxu pushed a commit that referenced this pull request Nov 20, 2024
🤖 I have created a release *beep* *boop*
---


##
[4.1.0](v4.0.0...v4.1.0)
(2024-11-20)


### Features

* add module for dns and bucket
([#145](#145))
([8b7202b](8b7202b))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc This pr contains a document
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants