feat: add new output eks which contains all outputs of module.eks #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dule's all outputs
dpappa
approved these changes
May 13, 2024
maxsxu
changed the title
maxsxu
changed the title
ciiiii
pushed a commit
that referenced
this pull request
May 21, 2024
🤖 I have created a release *beep* *boop* --- ## [3.0.0](v2.8.0...v3.0.0) (2024-05-21) ### ⚠ BREAKING CHANGES * use shared route table for public subnet ([#125](#125)) ### Features * add new output eks which contains all outputs of module.eks ([#131](#131)) ([6f7739e](6f7739e)) * add output eks for provide convenient approach to access eks module's all outputs ([6f7739e](6f7739e)) * **cluster_autoscaler:** removed old k8s versions, added new ones ([#120](#120)) ([853aba8](853aba8)) * Disable nodepool logging to cloudwatch by default ([#126](#126)) ([c9be3c1](c9be3c1)) * support disable nat gateway and use public subnet ([#132](#132)) ([4c1b508](4c1b508)) * Support single zone node_group ([#133](#133)) ([8038bdf](8038bdf)) * use shared route table for public subnet ([#125](#125)) ([12e5ff0](12e5ff0)) ### Bug Fixes * Correct default value ([#128](#128)) ([25d8171](25d8171)) * Optimize external-dns args to reduce api calls ([#124](#124)) ([5aa0166](5aa0166)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When using eks managed node groups, the ASGs are implicitly created by EKS Node Groups, we need to know the ASG names so we can manipulate these ASGs in the parent module. e.g, we can add tags, and disable the AZRebalance, etc.
Modifications
ekswhich contains all outputs of module.eks for provide convenient approach to access child module's outputs. Example, usemodule.sn_cluster.eks.eks_managed_node_groups_autoscaling_group_namesto access the list of the autoscaling group names created by EKS managed node groupsVerifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Documentation
no-need-doc