Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Disable nodepool logging to cloudwatch by default #126

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

dpappa
Copy link
Member

@dpappa dpappa commented Feb 20, 2024

(If this PR fixes a github issue, please add Fixes #<xyz>.)

Fixes #

(or if this PR is one task of a github issue, please add Master Issue: #<xyz> to link to the master issue.)

Master Issue: #

Motivation

Explain here the context, and why you're making that change. What is the problem you're trying to solve.

Disable cloudwatch logging to reduce redundant logs.

Modifications

Describe the modifications you've done.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Documentation

Check the box below.

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    (Please explain why)

  • doc

    (If this PR contains doc changes)

@dpappa dpappa requested a review from a team as a code owner February 20, 2024 16:18
Copy link
Contributor

@dpappa:Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

@github-actions github-actions bot added the doc-info-missing This pr needs to mark a document option in description label Feb 20, 2024
Copy link
Contributor

@dpappa:Thanks for providing doc info!

@github-actions github-actions bot added no-need-doc This pr does not need any document and removed doc-info-missing This pr needs to mark a document option in description labels Feb 20, 2024
@dpappa dpappa merged commit c9be3c1 into master Feb 27, 2024
7 checks passed
@dpappa dpappa deleted the dpappa/disable-cloudwatch-logging branch February 27, 2024 14:37
dpappa added a commit that referenced this pull request Feb 27, 2024
@dpappa dpappa mentioned this pull request Feb 27, 2024
4 tasks
dpappa added a commit that referenced this pull request Feb 27, 2024
ciiiii pushed a commit that referenced this pull request May 21, 2024
🤖 I have created a release *beep* *boop*
---


##
[3.0.0](v2.8.0...v3.0.0)
(2024-05-21)


### ⚠ BREAKING CHANGES

* use shared route table for public subnet
([#125](#125))

### Features

* add new output eks which contains all outputs of module.eks
([#131](#131))
([6f7739e](6f7739e))
* add output eks for provide convenient approach to access eks module's
all outputs
([6f7739e](6f7739e))
* **cluster_autoscaler:** removed old k8s versions, added new ones
([#120](#120))
([853aba8](853aba8))
* Disable nodepool logging to cloudwatch by default
([#126](#126))
([c9be3c1](c9be3c1))
* support disable nat gateway and use public subnet
([#132](#132))
([4c1b508](4c1b508))
* Support single zone node_group
([#133](#133))
([8038bdf](8038bdf))
* use shared route table for public subnet
([#125](#125))
([12e5ff0](12e5ff0))


### Bug Fixes

* Correct default value
([#128](#128))
([25d8171](25d8171))
* Optimize external-dns args to reduce api calls
([#124](#124))
([5aa0166](5aa0166))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-need-doc This pr does not need any document
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants