Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set create_iam_policies default to false #109

Merged
merged 1 commit into from
May 23, 2023

Conversation

maxsxu
Copy link
Member

@maxsxu maxsxu commented May 22, 2023

Motivation

The create_iam_policies is going to be deprecated as we do not allow iam:CreatePolicy in terraform-managed-cloud.

Modifications

set create_iam_policies default to false

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Documentation

Check the box below.

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    (Please explain why)

  • doc

    (If this PR contains doc changes)

@maxsxu maxsxu requested review from gengmao and addisonj May 22, 2023 02:07
@maxsxu maxsxu self-assigned this May 22, 2023
@maxsxu maxsxu requested a review from a team as a code owner May 22, 2023 02:07
@github-actions
Copy link
Contributor

@maxsxu:Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

@github-actions github-actions bot added the doc-info-missing This pr needs to mark a document option in description label May 22, 2023
@maxsxu maxsxu merged commit 2c4c2b3 into master May 23, 2023
@delete-merged-branch delete-merged-branch bot deleted the max/create_iam_policy_false branch May 23, 2023 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-info-missing This pr needs to mark a document option in description
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants