Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom token payload #1082

Merged
merged 3 commits into from
Aug 17, 2023
Merged

Support custom token payload #1082

merged 3 commits into from
Aug 17, 2023

Conversation

tuteng
Copy link
Member

@tuteng tuteng commented Aug 3, 2023

(If this PR fixes a github issue, please add Fixes #<xyz>.)

Fixes #

(or if this PR is one task of a github issue, please add Master Issue: #<xyz> to link to the master issue.)

Master Issue: #

Motivation

Explain here the context, and why you're making that change. What is the problem you're trying to solve.

Modifications

Describe the modifications you've done.

customPayload:
    superToken: "\\\"role\\\":[\\\"admin\\\"]|\\\"role2\\\":\\\"admin2\\\""
    nonSuperToken: "\\\"role\\\":[\\\"admin\\\",{{identity.entity.aliases.MOUNT_ACCESSOR.metadata.role_name}}]"

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Documentation

Check the box below.

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    (Please explain why)

  • doc

    (If this PR contains doc changes)

@tuteng tuteng requested review from sijie, addisonj and a team as code owners August 3, 2023 09:48
@github-actions
Copy link

github-actions bot commented Aug 3, 2023

@tuteng:Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

@github-actions github-actions bot added the doc-info-missing This pr needs to mark a document option in description label Aug 3, 2023
@tuteng tuteng requested review from fantapsody, ericsyh and a team August 3, 2023 09:49
@tuteng tuteng marked this pull request as draft August 3, 2023 14:32
@ericsyh ericsyh added this to the sn-platform-1.11 milestone Aug 4, 2023
@tuteng tuteng marked this pull request as ready for review August 8, 2023 11:22
@tuteng tuteng merged commit 5eb115c into master Aug 17, 2023
@tuteng tuteng deleted the fixed/vault-oidc-token-format branch August 17, 2023 08:59
ericsyh pushed a commit that referenced this pull request Aug 24, 2023
* Support custom token payload
* Upgrade vault init image

(cherry picked from commit 5eb115c)
ericsyh pushed a commit that referenced this pull request Aug 24, 2023
* Support custom token payload
* Upgrade vault init image

(cherry picked from commit 5eb115c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-info-missing This pr needs to mark a document option in description release/1.10.7
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants