fix: Declare isArrayBufferView as native Node.js function to resolve module import error #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hernanr99
changed the title
littlespex
approved these changes
Mar 4, 2024
littlespex
requested changes
Mar 4, 2024
littlespex
force-pushed
the
release/0.6.4
branch
from
7218bbe to
ec00da1
Compare
littlespex
approved these changes
Mar 4, 2024
littlespex
reviewed
Mar 4, 2024
Signed-off-by: hernan <[email protected]>
Signed-off-by: hernan <[email protected]>
Signed-off-by: Casey Occhialini <[email protected]>
Co-authored-by: Casey Occhialini <[email protected]> Signed-off-by: Hernán Reyes <[email protected]> Signed-off-by: hernan <[email protected]>
hernanr99
force-pushed
the
fix/decodeId3ImageFrame
branch
from
5ec25ca to
4c37290
Compare
Signed-off-by: Hernán Reyes <[email protected]>
felipeYoungi
approved these changes
Mar 4, 2024
mpollingerQualabs
approved these changes
Mar 4, 2024
littlespex
merged commit 2c94c86
into
streaming-video-technology-alliance:release/0.6.4
2 checks passed
littlespex
added a commit
that referenced
this pull request
Mar 4, 2024
…se/0.6.4 * chore: update version to 0.6.4 * fix: Declare isArrayBufferView as native Node.js function to resolve module import error (#81) * Remove isArrayBufferView import and create as auxiliary function see: #83 --------- Signed-off-by: Casey Occhialini <[email protected]> Signed-off-by: hernan <[email protected]> Signed-off-by: Hernán Reyes <[email protected]> Co-authored-by: Hernán Reyes <[email protected]>
littlespex
pushed a commit
to qualabs/common-media-library
that referenced
this pull request
Apr 5, 2024
…module import error (streaming-video-technology-alliance#81) * Remove isArrayBufferView import and create as auxiliary function see: streaming-video-technology-alliance#83 --------- Signed-off-by: hernan <[email protected]> Signed-off-by: Casey Occhialini <[email protected]> Signed-off-by: Hernán Reyes <[email protected]> Signed-off-by: Casey Occhialini <[email protected]>
littlespex
pushed a commit
to qualabs/common-media-library
that referenced
this pull request
Apr 5, 2024
…module import error (streaming-video-technology-alliance#81) * Remove isArrayBufferView import and create as auxiliary function see: streaming-video-technology-alliance#83 --------- Signed-off-by: hernan <[email protected]> Signed-off-by: Casey Occhialini <[email protected]> Signed-off-by: Hernán Reyes <[email protected]> Signed-off-by: Casey Occhialini <[email protected]>
littlespex
pushed a commit
to qualabs/common-media-library
that referenced
this pull request
Apr 5, 2024
…module import error (streaming-video-technology-alliance#81) * Remove isArrayBufferView import and create as auxiliary function see: streaming-video-technology-alliance#83 --------- Signed-off-by: hernan <[email protected]> Signed-off-by: Casey Occhialini <[email protected]> Signed-off-by: Hernán Reyes <[email protected]> Signed-off-by: Casey Occhialini <[email protected]>
littlespex
pushed a commit
that referenced
this pull request
Jun 5, 2024
…module import error (#81) * Remove isArrayBufferView import and create as auxiliary function see: #83 --------- Signed-off-by: hernan <[email protected]> Signed-off-by: Casey Occhialini <[email protected]> Signed-off-by: Hernán Reyes <[email protected]> Signed-off-by: Casey Occhialini <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request addresses a module import error encountered when installing the library in a project. The error manifested as follows:
The underlying cause was the dependency on isArrayBufferView in the util/types module of Node.js. To resolve this issue and avoid future conflicts with direct imports of Node.js modules, we decided to declare isArrayBufferView as a native function, thus eliminating the need to import it directly from util/types.
This change implements isArrayBufferView as an auxiliary function in the code, ensuring that the previous functionality remains intact while resolving the module import error.
Requirements Checklist