feat: CEA608/708 parser #75

hernanr99 · 2024-02-27T15:24:41Z

Description

We've implemented support for the CEA608/708 subtitles standard to our library, expanding its capabilities. In this update, alongside the feature implementation, we've initiated the integration with a basic set of tests.

Requirements Checklist

Unit Tests updated or fixed
Docs/guides updated

Signed-off-by: hernan <[email protected]>

…tputFilter instance Signed-off-by: hernan <[email protected]>

Signed-off-by: hernan <[email protected]>

lib/src/captions/cea608-708/utilities/utils.ts

Signed-off-by: hernan <[email protected]>

mpollingerQualabs

LGTM

avelad · 2024-03-01T12:29:47Z

One question, do you support the subtitles described in videojs/mux.js#439 ?

mpollingerQualabs · 2024-03-01T13:32:45Z

One question, do you support the subtitles described in videojs/mux.js#439 ?

Hey @avelad, do you have a playlists we could test with? Or should we try with the one on that PR?

avelad · 2024-03-01T13:44:41Z

One question, do you support the subtitles described in videojs/mux.js#439 ?

Hey @avelad, do you have a playlists we could test with? Or should we try with the one on that PR?

Yes, you can use:
Example Test Playlist: https://solutions.brightcove.com/wseymour/708-testing/playlist.m3u8

…eature/cea-608-708 Signed-off-by: hernan <[email protected]>

mpollingerQualabs · 2024-03-01T14:36:13Z

One question, do you support the subtitles described in videojs/mux.js#439 ?

Hey @avelad, do you have a playlists we could test with? Or should we try with the one on that PR?

Yes, you can use: Example Test Playlist: https://solutions.brightcove.com/wseymour/708-testing/playlist.m3u8

We've tried with that one but it doesn't seem to have a subtitle playlist. Could you provide us another one? Or what specific type of subtitle should we test?

Signed-off-by: hernan <[email protected]> Signed-off-by: Casey Occhialini <[email protected]>

* chore: update version to 0.6.3 * feat: Enhance ID3 Support: Implement APIC Functionality (streaming-video-technology-alliance#76) * chore: update @web/dev-server to address dependabot security issue (streaming-video-technology-alliance#79) --------- Signed-off-by: Casey Occhialini <[email protected]> Signed-off-by: Fernando Cuadro <[email protected]> Signed-off-by: Felipe Young <[email protected]> Signed-off-by: hernan <[email protected]> Signed-off-by: fernandocQualabs <[email protected]> Co-authored-by: fernandocQualabs <[email protected]> Co-authored-by: Felipe Young <[email protected]> Co-authored-by: hernan <[email protected]> Signed-off-by: Casey Occhialini <[email protected]>

Signed-off-by: Casey Occhialini <[email protected]>

…module import error (streaming-video-technology-alliance#81) * Remove isArrayBufferView import and create as auxiliary function see: streaming-video-technology-alliance#83 --------- Signed-off-by: hernan <[email protected]> Signed-off-by: Casey Occhialini <[email protected]> Signed-off-by: Hernán Reyes <[email protected]> Signed-off-by: Casey Occhialini <[email protected]>

Signed-off-by: Casey Occhialini <[email protected]>

Signed-off-by: hernan <[email protected]>

…tputFilter instance Signed-off-by: hernan <[email protected]> Signed-off-by: Casey Occhialini <[email protected]>

Signed-off-by: hernan <[email protected]>

Signed-off-by: hernan <[email protected]> Signed-off-by: Casey Occhialini <[email protected]>

Signed-off-by: hernan <[email protected]>

Signed-off-by: hernan <[email protected]> Signed-off-by: Casey Occhialini <[email protected]>

* chore: update version to 0.6.3 * feat: Enhance ID3 Support: Implement APIC Functionality (streaming-video-technology-alliance#76) * chore: update @web/dev-server to address dependabot security issue (streaming-video-technology-alliance#79) --------- Signed-off-by: Casey Occhialini <[email protected]> Signed-off-by: Fernando Cuadro <[email protected]> Signed-off-by: Felipe Young <[email protected]> Signed-off-by: hernan <[email protected]> Signed-off-by: fernandocQualabs <[email protected]> Co-authored-by: fernandocQualabs <[email protected]> Co-authored-by: Felipe Young <[email protected]> Co-authored-by: hernan <[email protected]>

Signed-off-by: Casey Occhialini <[email protected]>

…module import error (streaming-video-technology-alliance#81) * Remove isArrayBufferView import and create as auxiliary function see: streaming-video-technology-alliance#83 --------- Signed-off-by: hernan <[email protected]> Signed-off-by: Casey Occhialini <[email protected]> Signed-off-by: Hernán Reyes <[email protected]> Signed-off-by: Casey Occhialini <[email protected]>

Signed-off-by: Casey Occhialini <[email protected]>

…on-media-library into feature/cea-608-708 Signed-off-by: Casey Occhialini <[email protected]> # Conflicts: # CHANGELOG.md # lib/src/id3/util/utf8.ts

* Added CEA-608/708 methods Signed-off-by: hernan <[email protected]> Signed-off-by: Casey Occhialini <[email protected]> Co-authored-by: Casey Occhialini <[email protected]> Signed-off-by: Casey Occhialini <[email protected]>

* feat: CTA-608parser (#75) --------- Signed-off-by: hernan <[email protected]> Signed-off-by: Agajan Jumakuliyev <[email protected]> Signed-off-by: Casey Occhialini <[email protected]> Co-authored-by: Hernán Reyes <[email protected]> Co-authored-by: Agajan J <[email protected]> Co-authored-by: Casey Occhialini <[email protected]>

* feat: CTA-608parser (#75) --------- Signed-off-by: hernan <[email protected]> Signed-off-by: Agajan Jumakuliyev <[email protected]> Signed-off-by: Casey Occhialini <[email protected]> Co-authored-by: Hernán Reyes <[email protected]> Co-authored-by: Agajan J <[email protected]> Co-authored-by: Casey Occhialini <[email protected]> Signed-off-by: Casey Occhialini <[email protected]>

…se/0.7.0 * feat: CEA608/708 parser (#75) (#86) * feat: CTA-608parser (#75) --------- Signed-off-by: Casey Occhialini <[email protected]> Signed-off-by: hernan <[email protected]> Signed-off-by: Hernán Reyes <[email protected]> Signed-off-by: Nicolas Levy <[email protected]> Signed-off-by: Noelia Bentancor <[email protected]> Signed-off-by: Agajan Jumakuliyev <[email protected]> Co-authored-by: Hernán Reyes <[email protected]> Co-authored-by: Nicolas Levy <[email protected]> Co-authored-by: Noelia Bentancor <[email protected]> Co-authored-by: DuckyCB <[email protected]> Co-authored-by: Matías Rodriguez <[email protected]> Co-authored-by: Matías Rodriguez <[email protected]> Co-authored-by: Patricio Carrau <[email protected]> Co-authored-by: Agajan J <[email protected]>

* feat: CTA-608parser (#75) --------- Signed-off-by: hernan <[email protected]> Signed-off-by: Agajan Jumakuliyev <[email protected]> Signed-off-by: Casey Occhialini <[email protected]> Co-authored-by: Hernán Reyes <[email protected]> Co-authored-by: Agajan J <[email protected]> Co-authored-by: Casey Occhialini <[email protected]> Signed-off-by: Casey Occhialini <[email protected]>

hernanr99 requested review from a team as code owners February 27, 2024 15:24

hernanr99 marked this pull request as draft February 27, 2024 15:25

hernanr99 changed the title ~~Feature: CEA608/708 Subtitles Compatibility~~ feat: CEA608/708 parser Feb 27, 2024

hernanr99 force-pushed the feature/cea-608-708 branch from 29d221a to 8945ae1 Compare February 27, 2024 15:45

hernanr99 added 10 commits February 27, 2024 12:54

Added CEA-608/708 methods

e9682d0

Signed-off-by: hernan <[email protected]>

Fix function reset on Cea608Channel, check function reset exist on ou…

34b989e

…tputFilter instance Signed-off-by: hernan <[email protected]>

Added penState tests

05f74a4

Signed-off-by: hernan <[email protected]>

Added some row tests

516da30

Signed-off-by: hernan <[email protected]>

Added captionScreen, cea608Channel and cea608Parser tests

2f64eff

Signed-off-by: hernan <[email protected]>

Refactor: all classes were extracted into individual files.

18e97c0

Signed-off-by: hernan <[email protected]>

Remove unneccessary comments

2d45327

Signed-off-by: hernan <[email protected]>

Request changes, fix tsdoc

298ba8c

Signed-off-by: hernan <[email protected]>

Remove unnecessary comments

4b0a9ea

Signed-off-by: hernan <[email protected]>

Modify changelog

a5c9def

Signed-off-by: hernan <[email protected]>

hernanr99 force-pushed the feature/cea-608-708 branch from 8945ae1 to a5c9def Compare February 27, 2024 15:55

littlespex requested changes Feb 27, 2024

View reviewed changes

lib/src/captions/cea608-708/utilities/utils.ts Outdated Show resolved Hide resolved

hernanr99 added 2 commits February 28, 2024 11:20

Add types

53a6b21

Signed-off-by: hernan <[email protected]>

Request changes

7b87581

Signed-off-by: hernan <[email protected]>

felipeYoungi marked this pull request as ready for review February 29, 2024 14:51

mpollingerQualabs previously approved these changes Feb 29, 2024

View reviewed changes

Merge branch 'main' of github.com:qualabs/common-media-library into f…

9cf6931

…eature/cea-608-708 Signed-off-by: hernan <[email protected]>

hernanr99 dismissed mpollingerQualabs’s stale review via 9cf6931 March 1, 2024 14:31

hernanr99 requested a review from littlespex March 1, 2024 17:20

felipeYoungi marked this pull request as draft March 1, 2024 20:11

felipeYoungi marked this pull request as ready for review March 1, 2024 20:12

hernanr99 and others added 23 commits April 5, 2024 11:19

Request changes

8ad2744

Signed-off-by: hernan <[email protected]> Signed-off-by: Casey Occhialini <[email protected]>

chore: update version to 0.6.4

bdb63fa

Signed-off-by: Casey Occhialini <[email protected]>

chore: move files to cta/608

fbe8f8f

Signed-off-by: Casey Occhialini <[email protected]>

no message

e717194

Signed-off-by: Casey Occhialini <[email protected]>

Added CEA-608/708 methods

42705ef

Signed-off-by: hernan <[email protected]>

Fix function reset on Cea608Channel, check function reset exist on ou…

f41c2e9

…tputFilter instance Signed-off-by: hernan <[email protected]> Signed-off-by: Casey Occhialini <[email protected]>

Added penState tests

e56df8f

Signed-off-by: hernan <[email protected]>

Added some row tests

63a33ff

Signed-off-by: hernan <[email protected]> Signed-off-by: Casey Occhialini <[email protected]>

Added captionScreen, cea608Channel and cea608Parser tests

9ec1114

Signed-off-by: hernan <[email protected]> Signed-off-by: Casey Occhialini <[email protected]>

Refactor: all classes were extracted into individual files.

adbd3bb

Signed-off-by: hernan <[email protected]>

Remove unneccessary comments

db5e0da

Signed-off-by: hernan <[email protected]> Signed-off-by: Casey Occhialini <[email protected]>

Request changes, fix tsdoc

daf4c3e

Signed-off-by: hernan <[email protected]> Signed-off-by: Casey Occhialini <[email protected]>

Remove unnecessary comments

231d530

Signed-off-by: hernan <[email protected]> Signed-off-by: Casey Occhialini <[email protected]>

Add types

010a009

Signed-off-by: hernan <[email protected]> Signed-off-by: Casey Occhialini <[email protected]>

Request changes

c0da067

Signed-off-by: hernan <[email protected]> Signed-off-by: Casey Occhialini <[email protected]>

chore: update version to 0.6.4

d673bcc

Signed-off-by: Casey Occhialini <[email protected]>

chore: move files to cta/608

547af6d

Signed-off-by: Casey Occhialini <[email protected]>

no message

953b8e4

Signed-off-by: Casey Occhialini <[email protected]>

Merge branch 'feature/cea-608-708' of https://github.com/qualabs/comm…

2752a19

…on-media-library into feature/cea-608-708 Signed-off-by: Casey Occhialini <[email protected]> # Conflicts: # CHANGELOG.md # lib/src/id3/util/utf8.ts

littlespex merged commit 94744b5 into streaming-video-technology-alliance:feat/608 Apr 5, 2024
1 of 2 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: CEA608/708 parser #75

feat: CEA608/708 parser #75

hernanr99 commented Feb 27, 2024

mpollingerQualabs left a comment

avelad commented Mar 1, 2024

mpollingerQualabs commented Mar 1, 2024 •

edited

Loading

avelad commented Mar 1, 2024

mpollingerQualabs commented Mar 1, 2024

feat: CEA608/708 parser #75

feat: CEA608/708 parser #75

Conversation

hernanr99 commented Feb 27, 2024

Description

Requirements Checklist

mpollingerQualabs left a comment

Choose a reason for hiding this comment

avelad commented Mar 1, 2024

mpollingerQualabs commented Mar 1, 2024 • edited Loading

avelad commented Mar 1, 2024

mpollingerQualabs commented Mar 1, 2024

mpollingerQualabs commented Mar 1, 2024 •

edited

Loading