Feature/add unit tests #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
littlespex
requested changes
Feb 21, 2024
Signed-off-by: Felipe Young <[email protected]>
Signed-off-by: Felipe Young <[email protected]>
Signed-off-by: Felipe Young <[email protected]>
Signed-off-by: Felipe Young <[email protected]>
felipeYoungi
force-pushed
the
feature/add-unit-tests
branch
from
143fc93 to
6de5901
Compare
added 3 commits
February 21, 2024 16:12
Signed-off-by: Felipe Young <[email protected]>
…eature/add-unit-tests
Signed-off-by: Felipe Young <[email protected]>
mpollingerQualabs
previously approved these changes
Feb 21, 2024
littlespex
requested changes
Feb 21, 2024
littlespex
approved these changes
Feb 21, 2024
littlespex
requested changes
Feb 21, 2024
Signed-off-by: Felipe Young <[email protected]>
added 2 commits
February 22, 2024 11:15
Signed-off-by: Felipe Young <[email protected]>
Signed-off-by: Felipe Young <[email protected]>
littlespex
approved these changes
Feb 22, 2024
littlespex
merged commit 16bf71f
into
streaming-video-technology-alliance:main
2 checks passed
hernanr99
pushed a commit
to qualabs/common-media-library
that referenced
this pull request
Feb 27, 2024
see: streaming-video-technology-alliance#74 --------- Signed-off-by: Felipe Young <[email protected]> Co-authored-by: Fernando Cuadro <[email protected]> Signed-off-by: hernan <[email protected]>
fernandocQualabs
added a commit
to qualabs/common-media-library
that referenced
this pull request
Feb 27, 2024
see: streaming-video-technology-alliance#74 --------- Signed-off-by: Felipe Young <[email protected]> Co-authored-by: Fernando Cuadro <[email protected]> Signed-off-by: Fernando Cuadro <[email protected]>
littlespex
pushed a commit
to qualabs/common-media-library
that referenced
this pull request
Apr 5, 2024
see: streaming-video-technology-alliance#74 --------- Signed-off-by: Felipe Young <[email protected]> Co-authored-by: Fernando Cuadro <[email protected]> Signed-off-by: Casey Occhialini <[email protected]>
littlespex
pushed a commit
to qualabs/common-media-library
that referenced
this pull request
Apr 5, 2024
see: streaming-video-technology-alliance#74 --------- Signed-off-by: Felipe Young <[email protected]> Co-authored-by: Fernando Cuadro <[email protected]> Signed-off-by: Casey Occhialini <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please describe the changes.
Added helper functions unit tests found on hls.js repo that were missing in the common media library.
The methods tested are:
Requirements Checklist