Add request package (CommonMediaRequest and CommonMediaResponse) #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
littlespex
requested changes
May 23, 2023
|
BTW, I suggest not inserting semicolons in source code and add |
littlespex
reviewed
Oct 19, 2023
littlespex
requested changes
Oct 27, 2023
There was a problem hiding this comment.
Everything looks good but there are a few book keeping items to address:
- There needs to be a change log entry for this work. I've edited the PR to point to the 0.5.0 release branch, we can add this work to that release.
- DCO is now enabled for all commits. Follow the instructs here to update the commits for this PR. https://github.com/streaming-video-technology-alliance/common-media-library/pull/18/checks?check_run_id=18033214696
- The tests are not working due to a quirk in the build system. See code suggestion for fix.
dsparacio
approved these changes
Nov 2, 2023
Signed-off-by: Bertrand Berthelot <[email protected]>
Signed-off-by: Bertrand Berthelot <[email protected]>
Signed-off-by: Bertrand Berthelot <[email protected]>
Signed-off-by: Bertrand Berthelot <[email protected]>
Signed-off-by: Bertrand Berthelot <[email protected]>
Signed-off-by: Bertrand Berthelot <[email protected]>
- startTime property as required - add encodedBodySize property Signed-off-by: Bertrand Berthelot <[email protected]>
…ing.encodedBodySize) Signed-off-by: Bertrand Berthelot <[email protected]>
Signed-off-by: Bertrand Berthelot <[email protected]>
Signed-off-by: Bertrand Berthelot <[email protected]>
* chore: change npm scope to svta Signed-off-by: Bertrand Berthelot <[email protected]>
Signed-off-by: Bertrand Berthelot <[email protected]>
* chore: add notice attribution file * chore: add notice attribution file * fix: export cjs version of the library * chore: switch to inline source maps * chore: update version to 0.4.3 Signed-off-by: Bertrand Berthelot <[email protected]>
Signed-off-by: Bertrand Berthelot <[email protected]>
Signed-off-by: Bertrand Berthelot <[email protected]>
* fix: list default as last export in package json Signed-off-by: Bertrand Berthelot <[email protected]>
Signed-off-by: Bertrand Berthelot <[email protected]>
Signed-off-by: Casey Occhialini <[email protected]> Signed-off-by: Bertrand Berthelot <[email protected]>
Signed-off-by: Casey Occhialini <[email protected]> Signed-off-by: Bertrand Berthelot <[email protected]>
Signed-off-by: Casey Occhialini <[email protected]> Signed-off-by: Bertrand Berthelot <[email protected]>
Signed-off-by: Casey Occhialini <[email protected]> Signed-off-by: Bertrand Berthelot <[email protected]>
Signed-off-by: Bertrand Berthelot <[email protected]>
Signed-off-by: Casey Occhialini <[email protected]> Signed-off-by: Bertrand Berthelot <[email protected]>
* fix: rename CmcdParam file to match exported const Signed-off-by: Casey Occhialini <[email protected]> Signed-off-by: Bertrand Berthelot <[email protected]>
Signed-off-by: Casey Occhialini <[email protected]> Signed-off-by: Bertrand Berthelot <[email protected]>
Signed-off-by: Casey Occhialini <[email protected]> Signed-off-by: Bertrand Berthelot <[email protected]>
Signed-off-by: Casey Occhialini <[email protected]> Signed-off-by: Bertrand Berthelot <[email protected]>
Signed-off-by: Casey Occhialini <[email protected]> Signed-off-by: Bertrand Berthelot <[email protected]>
Signed-off-by: Casey Occhialini <[email protected]> Signed-off-by: Bertrand Berthelot <[email protected]>
Signed-off-by: Casey Occhialini <[email protected]> Signed-off-by: Bertrand Berthelot <[email protected]>
Signed-off-by: Bertrand Berthelot <[email protected]>
Signed-off-by: Casey Occhialini <[email protected]> Signed-off-by: Bertrand Berthelot <[email protected]>
bbert
force-pushed
the
common-media-request
branch
from
aff8d44 to
e56e77c
Compare
Signed-off-by: Bertrand Berthelot <[email protected]>
Signed-off-by: Bertrand Berthelot <[email protected]>
Signed-off-by: Bertrand Berthelot <[email protected]>
Signed-off-by: Bertrand Berthelot <[email protected]>
Signed-off-by: Bertrand Berthelot <[email protected]>
bbert
force-pushed
the
common-media-request
branch
from
cf3c80b to
a105404
Compare
Signed-off-by: Bertrand Berthelot <[email protected]>
bbert
force-pushed
the
common-media-request
branch
from
2d54b18 to
986f776
Compare
Signed-off-by: Bertrand Berthelot <[email protected]>
littlespex
approved these changes
Nov 13, 2023
littlespex
added a commit
that referenced
this pull request
Nov 14, 2023
* chore: update version to 0.5.0 Signed-off-by: Casey Occhialini <[email protected]> * Issue/35-cmsd (#36) * add: structured field implementation * add: CMSD utiles * add CMSD encode tests * doc: add api docs for CMSD items * chore: update version to 0.5.0 * chore: update changelog * chore: reorganize source files * chore: update github actions to checkout submodules * add cmcd key filtering * add: option to not use Symbol in encodings * add: api extractor support --------- Signed-off-by: Casey Occhialini <[email protected]> * Add request package (CommonMediaRequest and CommonMediaResponse) (#18) * CommonMediaRequest.headers as optional property * Add request property in CommonMediaResponse * Update ResourceTiming: - startTime property as required - add encodedBodySize property * CommobMediaResponse: remove length prroperty (replaced by resourceTiming.encodedBodySize) * Remove application based request execution functionnality * Rename Request/ResponsePlugin to Request/ResponseInterceptor * Add CHANGELOG for request/response API * package.json: add keywords for Common Media Request/Response * request package: add tsdoc release tag * Reorder export in alphabetical order --------- Signed-off-by: Bertrand Berthelot <[email protected]> --------- Signed-off-by: Casey Occhialini <[email protected]> Signed-off-by: Bertrand Berthelot <[email protected]> Co-authored-by: Bertrand Berthelot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add common API for player requests and responses, following discussion on dash.js: Dash-Industry-Forum/dash.js#4152
This API provides also a plugin request and response callback prototype that can be used as input in every player in order to enable applications to manipulate requests and responses.
A sample test application based on dash.js and using this API will be provided withing dash.js repo.
Requirements Checklist