Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor shaka-player to use CML's ID3 utilities #59

Open
littlespex opened this issue Jan 9, 2024 · 2 comments
Open

Refactor shaka-player to use CML's ID3 utilities #59

littlespex opened this issue Jan 9, 2024 · 2 comments

Comments

@littlespex
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
The ID3 utility functions in CML are based in part on the ones in shaka-player. Now that the ID3 functionality has been consolidated from the player libraries, the players should be refactored to use CML's version.

Describe the solution you'd like
Refactor shaka-player to use CML's ID3 utilities.

@felipeYoungi
Copy link
Contributor

Shaka uses google closure library to manage it’s dependencies, now turns out Google Closure Library isn’t compatible with ES6, so we can’t import CML through this method.
On top of that, there’s another situation worth mentioning: Google Clousure Libray is being deprecated on August 1, 2024.
As a consequence of this we think our best option is to keep this on hold for now(instead of trying to come up with strategies that will not be very useful after Google Clousure Library deprecation), until Shaka figures out what strategy is going to take in this matter.
@littlespex what do you think about this?

@littlespex
Copy link
Collaborator Author

I agree this should be kept on hold until Shaka migrates away from Closure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

2 participants