Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

potential glitch of CANCEL #10

Open
DeepSOIC opened this issue Mar 12, 2021 · 2 comments
Open

potential glitch of CANCEL #10

DeepSOIC opened this issue Mar 12, 2021 · 2 comments

Comments

@DeepSOIC
Copy link

https://github.com/strawlab/Miriam/blob/main/Programs/Serial_003/Serial_003.ino#L264

computePIDs calls PID_MIDDLE.Compute(), which has a chance to overwrite Output_MIDDLE variable, before it is applied as actual heating power. This can cause Miriam to not turn off some of the heaters sometimes.

@astraw astraw closed this as completed in d4728d3 Mar 13, 2021
@astraw
Copy link
Member

astraw commented Mar 13, 2021

Thanks for the catch.

(The entire state machine, with global variables changed from within a library, could definitely be improved!)

@DeepSOIC
Copy link
Author

Seems to me it's not fixed yet. Writing to Output_... variables does not affect actual heater power, analogWrite(...) calls do, and they are only in computePIDs() function.

@astraw astraw reopened this Mar 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants