Skip to content
This repository has been archived by the owner on Apr 22, 2021. It is now read-only.

Fix URI generated for canonical tag #76

Closed
mxgnr opened this issue Apr 7, 2020 · 2 comments
Closed

Fix URI generated for canonical tag #76

mxgnr opened this issue Apr 7, 2020 · 2 comments

Comments

@mxgnr
Copy link
Contributor

mxgnr commented Apr 7, 2020

Hi there,

First of all, thanks for making this useful plugin which i'm currently using for a project.

My main concern was about the canonical tag generated by the plugin, since i figured out that it is not working properly with my WP domain configuration :

  • Main domain of the WP instance :
    https://www.example.com/some-subfolder/ ( this is actually the value returned by home_url() )
  • Other domain added via the multi-domain plugin settings :
    https://subdomain.example.com/some-subfolder/

The other domain is working properly with this plugin, but when i browse to a category for example and i check the canonical URL generated by the plugin, it will display :

  • <link rel="canonical" href="https://www.example.com/category/my-category/" />
  • instead of <link rel="canonical" href="https://www.example.com/some-subfolder/category/my-category/" />.

I've tried some changes by setting the URI according to home_url() WP configuration instead of making it from scratch as it is currently, which seems to be working but might need some additional tests. (See #75)

Feel free to check if you can confirm this issue.

@straube
Copy link
Owner

straube commented Apr 10, 2020

Hey @maxgranier, thanks for your contribution! I'll try to test it over this coming weekend and I let you know if there is any issue. Otherwise, I'll go ahead and merge your PR.

@straube
Copy link
Owner

straube commented Aug 2, 2020

@maxgranier The changes you made were finally released in version 1.0.6.

@straube straube closed this as completed Aug 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants