Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Hot Encoding to the RNN model #447

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Add Hot Encoding to the RNN model #447

wants to merge 1 commit into from

Conversation

tahifahimi
Copy link

Fixes Issue

Closes #184

Changes proposed

  • convert the encoding from on-Hot encoding to ordinary encoding

Change the encoding in the RNN model (one hot encoding is added to the model)

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

@eldraco
Copy link
Collaborator

eldraco commented Feb 6, 2024

Hi @tahifahimi , thanks for the PR. We are going to be checking it. Please edit the PR and do it again to the develop branch, and not the master branch. Thanks!

@tahifahimi tahifahimi changed the base branch from master to develop February 6, 2024 18:53
@tahifahimi
Copy link
Author

Hi Sebastian,
I changed the base. Thanks for noticing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

To change the LSTM into using numbers and not the discretization
2 participants
@tahifahimi @eldraco