Introduce Webpack #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This does not represent any functional change to the behavior of the library. Since this component is getting reasonably complex, this diff adds bundling of files via Webpack. I have broken off a first small piece into geometry.js just as an example, and we should continue to split things up further. Notes: - Our webpack config emits a umd compatible module. Currently in master we only support es6 style modules. - See the notes in ./copy-to-example.sh to see how we are using the dist of this lib in the example app - Some useful resources: https://webpack.js.org/guides/author-libraries/ and https://github.com/kalcifer/webpack-library-example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does not represent any functional change to the behavior of the library. Since this component is getting reasonably complex, this diff adds bundling of files via Webpack. I have broken off a first small piece into geometry.js just as an example, and we should continue to split things up further.
Notes: